* [PATCH] ASoC: pcm: If pmdown_time is zero then shut down DAPM immediately
@ 2012-02-08 20:11 Mark Brown
2012-02-09 8:33 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2012-02-08 20:11 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown
Since we've already got logic to special case immediate teardown of the
stream we may as well use it if the pmdown_time has been set to zero by
the application layer instead of scheduling a work item with zero delay.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/soc-pcm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index ef28dd5..d7bb268 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -369,7 +369,7 @@ static int soc_pcm_close(struct snd_pcm_substream *substream)
cpu_dai->runtime = NULL;
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
- if (codec->ignore_pmdown_time ||
+ if (!rtd->pmdown_time || codec->ignore_pmdown_time ||
rtd->dai_link->ignore_pmdown_time) {
/* powered down playback stream now */
snd_soc_dapm_stream_event(rtd,
--
1.7.9.rc1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: pcm: If pmdown_time is zero then shut down DAPM immediately
2012-02-08 20:11 [PATCH] ASoC: pcm: If pmdown_time is zero then shut down DAPM immediately Mark Brown
@ 2012-02-09 8:33 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2012-02-09 8:33 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, patches
On Wed, 2012-02-08 at 20:11 +0000, Mark Brown wrote:
> Since we've already got logic to special case immediate teardown of the
> stream we may as well use it if the pmdown_time has been set to zero by
> the application layer instead of scheduling a work item with zero delay.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/soc-pcm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index ef28dd5..d7bb268 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -369,7 +369,7 @@ static int soc_pcm_close(struct snd_pcm_substream *substream)
> cpu_dai->runtime = NULL;
>
> if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
> - if (codec->ignore_pmdown_time ||
> + if (!rtd->pmdown_time || codec->ignore_pmdown_time ||
> rtd->dai_link->ignore_pmdown_time) {
> /* powered down playback stream now */
> snd_soc_dapm_stream_event(rtd,
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-09 8:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-08 20:11 [PATCH] ASoC: pcm: If pmdown_time is zero then shut down DAPM immediately Mark Brown
2012-02-09 8:33 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).