From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/8] ALSA: core: Constify the name in new kcontrols
Date: Fri, 17 Feb 2012 09:50:30 +0000 [thread overview]
Message-ID: <1329472230.3972.10.camel@odin> (raw)
In-Reply-To: <1329458170-22119-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Thu, 2012-02-16 at 21:56 -0800, Mark Brown wrote:
> We never modify it and this lets us use a const string as the name without
> warnings.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> include/sound/control.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/sound/control.h b/include/sound/control.h
> index b2796e8..57815f6 100644
> --- a/include/sound/control.h
> +++ b/include/sound/control.h
> @@ -40,7 +40,7 @@ struct snd_kcontrol_new {
> snd_ctl_elem_iface_t iface; /* interface identifier */
> unsigned int device; /* device/client number */
> unsigned int subdevice; /* subdevice (substream) number */
> - unsigned char *name; /* ASCII name of item */
> + const unsigned char *name; /* ASCII name of item */
> unsigned int index; /* index of item */
> unsigned int access; /* access rights */
> unsigned int count; /* count of same elements */
All
Acked-by: Liam Girdwood <lrg@ti.com>
I'll do some incremental updates for platform and ABE support.
Liam
prev parent reply other threads:[~2012-02-17 9:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 5:56 [PATCH 1/8] ALSA: core: Constify the name in new kcontrols Mark Brown
2012-02-17 5:56 ` [PATCH 2/8] ASoC: dapm: Unexport snd_soc_dapm_new_control() Mark Brown
2012-02-17 5:56 ` [PATCH 3/8] ASoC: dapm: Refactor snd_soc_dapm_new_widget() to return the widget Mark Brown
2012-02-17 5:56 ` [PATCH 4/8] ASoC: dapm: Supply the DAI and substream when calling stream events Mark Brown
2012-02-17 5:56 ` [PATCH 5/8] ASoC: dapm: Constify lots of names that are never modified Mark Brown
2012-02-17 5:56 ` [PATCH 6/8] ASoC: dapm: Implement and instantiate DAI widgets Mark Brown
2012-02-17 8:40 ` Vinod Koul
2012-02-17 10:39 ` Liam Girdwood
2012-02-22 12:35 ` Vinod Koul
2012-02-22 12:43 ` Mark Brown
2012-02-22 13:01 ` Vinod Koul
2012-02-22 13:29 ` Mark Brown
2012-02-23 6:50 ` Vinod Koul
2012-02-23 15:25 ` Mark Brown
2012-02-17 5:56 ` [PATCH 7/8] ASoC: dapm: Convert stream events to use " Mark Brown
2012-02-17 5:56 ` [PATCH 8/8] ASoC: wm8994: Convert to use DAI widget routing rather than streams Mark Brown
2012-02-17 9:50 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329472230.3972.10.camel@odin \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox