* [PATCH] ASoC: core: Split the union for CODEC/platform in the DAI
@ 2012-03-02 16:19 Mark Brown
2012-03-02 17:14 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2012-03-02 16:19 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown
There's now core code which falls back to global CODEC operations for
DAI calls that needs to be able to tell if it's dealing with a CPU or
CODEC DAI and given the small number of DAIs in a typical system and
overall memory usage pattern saving a pointer per DAI is really not
worth the effort.
Reported-by: Ian Lartey <ian@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
include/sound/soc-dai.h | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h
index d474128..868f4b6 100644
--- a/include/sound/soc-dai.h
+++ b/include/sound/soc-dai.h
@@ -250,10 +250,9 @@ struct snd_soc_dai {
unsigned int rate;
/* parent platform/codec */
- union {
- struct snd_soc_platform *platform;
- struct snd_soc_codec *codec;
- };
+ struct snd_soc_platform *platform;
+ struct snd_soc_codec *codec;
+
struct snd_soc_card *card;
struct list_head list;
--
1.7.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: core: Split the union for CODEC/platform in the DAI
2012-03-02 16:19 [PATCH] ASoC: core: Split the union for CODEC/platform in the DAI Mark Brown
@ 2012-03-02 17:14 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2012-03-02 17:14 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, patches
On Fri, 2012-03-02 at 16:19 +0000, Mark Brown wrote:
> There's now core code which falls back to global CODEC operations for
> DAI calls that needs to be able to tell if it's dealing with a CPU or
> CODEC DAI and given the small number of DAIs in a typical system and
> overall memory usage pattern saving a pointer per DAI is really not
> worth the effort.
>
> Reported-by: Ian Lartey <ian@opensource.wolfsonmicro.com>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-02 17:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-02 16:19 [PATCH] ASoC: core: Split the union for CODEC/platform in the DAI Mark Brown
2012-03-02 17:14 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).