* [PATCH v2] ASoC: omap-pcm: Free dma buffers in case of error.
@ 2012-04-25 2:02 Oleg Matcovschi
2012-04-25 6:25 ` Jarkko Nikula
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Oleg Matcovschi @ 2012-04-25 2:02 UTC (permalink / raw)
To: linux-omap, alsa-devel
Cc: peter.ujfalusi, jarkko.nikula, lrg, broonie, perex, tiwai,
Oleg Matcovschi
Change-Id: I4ba9de0de4681332539246ccc5e11a7a8fb32e79
Signed-off-by: Oleg Matcovschi <oleg.matcovschi@ti.com>
---
v1:
initial revision
v2:
resending patch including maintainers
sound/soc/omap/omap-pcm.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
index a2a464f..380a5bd 100644
--- a/sound/soc/omap/omap-pcm.c
+++ b/sound/soc/omap/omap-pcm.c
@@ -414,6 +414,10 @@ static int omap_pcm_new(struct snd_soc_pcm_runtime *rtd)
}
out:
+ /* free preallocated buffers in case of error */
+ if (ret)
+ omap_pcm_free_dma_buffers(pcm);
+
return ret;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] ASoC: omap-pcm: Free dma buffers in case of error.
2012-04-25 2:02 [PATCH v2] ASoC: omap-pcm: Free dma buffers in case of error Oleg Matcovschi
@ 2012-04-25 6:25 ` Jarkko Nikula
2012-04-25 8:09 ` Mark Brown
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jarkko Nikula @ 2012-04-25 6:25 UTC (permalink / raw)
To: Oleg Matcovschi
Cc: linux-omap, alsa-devel, peter.ujfalusi, lrg, broonie, perex,
tiwai
On 04/25/2012 05:02 AM, Oleg Matcovschi wrote:
> Change-Id: I4ba9de0de4681332539246ccc5e11a7a8fb32e79
> Signed-off-by: Oleg Matcovschi <oleg.matcovschi@ti.com>
> ---
> v1:
> initial revision
> v2:
> resending patch including maintainers
>
> sound/soc/omap/omap-pcm.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] ASoC: omap-pcm: Free dma buffers in case of error.
2012-04-25 2:02 [PATCH v2] ASoC: omap-pcm: Free dma buffers in case of error Oleg Matcovschi
2012-04-25 6:25 ` Jarkko Nikula
@ 2012-04-25 8:09 ` Mark Brown
2012-04-25 8:55 ` Peter Ujfalusi
2012-04-25 16:18 ` Liam Girdwood
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2012-04-25 8:09 UTC (permalink / raw)
To: Oleg Matcovschi
Cc: linux-omap, alsa-devel, peter.ujfalusi, jarkko.nikula, lrg, perex,
tiwai
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
On Tue, Apr 24, 2012 at 07:02:02PM -0700, Oleg Matcovschi wrote:
> Change-Id: I4ba9de0de4681332539246ccc5e11a7a8fb32e79
> Signed-off-by: Oleg Matcovschi <oleg.matcovschi@ti.com>
Don't include Change-Ids in upstream submissions, they only make sense
within whatever private development tree you are using.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ASoC: omap-pcm: Free dma buffers in case of error.
2012-04-25 2:02 [PATCH v2] ASoC: omap-pcm: Free dma buffers in case of error Oleg Matcovschi
2012-04-25 6:25 ` Jarkko Nikula
2012-04-25 8:09 ` Mark Brown
@ 2012-04-25 8:55 ` Peter Ujfalusi
2012-04-25 16:18 ` Liam Girdwood
3 siblings, 0 replies; 5+ messages in thread
From: Peter Ujfalusi @ 2012-04-25 8:55 UTC (permalink / raw)
To: Oleg Matcovschi
Cc: linux-omap, alsa-devel, jarkko.nikula, lrg, broonie, perex, tiwai
On 04/25/2012 05:02 AM, Oleg Matcovschi wrote:
> Change-Id: I4ba9de0de4681332539246ccc5e11a7a8fb32e79
> Signed-off-by: Oleg Matcovschi <oleg.matcovschi@ti.com>
> ---
> v1:
> initial revision
> v2:
> resending patch including maintainers
>
> sound/soc/omap/omap-pcm.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ASoC: omap-pcm: Free dma buffers in case of error.
2012-04-25 2:02 [PATCH v2] ASoC: omap-pcm: Free dma buffers in case of error Oleg Matcovschi
` (2 preceding siblings ...)
2012-04-25 8:55 ` Peter Ujfalusi
@ 2012-04-25 16:18 ` Liam Girdwood
3 siblings, 0 replies; 5+ messages in thread
From: Liam Girdwood @ 2012-04-25 16:18 UTC (permalink / raw)
To: Oleg Matcovschi
Cc: linux-omap, alsa-devel, peter.ujfalusi, jarkko.nikula, broonie,
perex, tiwai
On Tue, 2012-04-24 at 19:02 -0700, Oleg Matcovschi wrote:
> Change-Id: I4ba9de0de4681332539246ccc5e11a7a8fb32e79
> Signed-off-by: Oleg Matcovschi <oleg.matcovschi@ti.com>
> ---
> v1:
> initial revision
> v2:
> resending patch including maintainers
>
> sound/soc/omap/omap-pcm.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
Now applied for 3.4 with change ID removed.
Thanks
Liam
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-04-25 16:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-25 2:02 [PATCH v2] ASoC: omap-pcm: Free dma buffers in case of error Oleg Matcovschi
2012-04-25 6:25 ` Jarkko Nikula
2012-04-25 8:09 ` Mark Brown
2012-04-25 8:55 ` Peter Ujfalusi
2012-04-25 16:18 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).