From: Ricardo Neri <ricardo.neri@ti.com>
To: broonie@opensource.wolfsonmicro.com, lrg@ti.com
Cc: x0055901@ti.com, peter.ujfalusi@ti.com, s-guiriec@ti.com,
linux-omap@vger.kernel.org, alsa-devel@alsa-project.org,
Ricardo Neri <ricardo.neri@ti.com>
Subject: [PATCH 03/11] ASoC: OMAP: HDMI: Change error values in HDMI CPU DAI
Date: Fri, 18 May 2012 01:42:35 -0500 [thread overview]
Message-ID: <1337323363-11449-4-git-send-email-ricardo.neri@ti.com> (raw)
In-Reply-To: <1337323363-11449-1-git-send-email-ricardo.neri@ti.com>
When getting the needed resources fails, return -ENODEV. This is more
in line with other drivers do and it gives a more descriptive error.
Signed-off-by: Ricardo Neri <ricardo.neri@ti.com>
---
sound/soc/omap/omap-hdmi.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/omap/omap-hdmi.c b/sound/soc/omap/omap-hdmi.c
index 0925a46..b889f76 100644
--- a/sound/soc/omap/omap-hdmi.c
+++ b/sound/soc/omap/omap-hdmi.c
@@ -106,7 +106,7 @@ static __devinit int omap_hdmi_probe(struct platform_device *pdev)
hdmi_rsrc = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!hdmi_rsrc) {
dev_err(&pdev->dev, "Cannot obtain IORESOURCE_MEM HDMI\n");
- return -EINVAL;
+ return -ENODEV;
}
omap_hdmi_dai_dma_params.port_addr = hdmi_rsrc->start
@@ -115,7 +115,7 @@ static __devinit int omap_hdmi_probe(struct platform_device *pdev)
hdmi_rsrc = platform_get_resource(pdev, IORESOURCE_DMA, 0);
if (!hdmi_rsrc) {
dev_err(&pdev->dev, "Cannot obtain IORESOURCE_DMA HDMI\n");
- return -EINVAL;
+ return -ENODEV;
}
omap_hdmi_dai_dma_params.dma_req = hdmi_rsrc->start;
--
1.7.5.4
next prev parent reply other threads:[~2012-05-18 6:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 6:42 [PATCH 00/11] ASoC: OMAP: HDMI: Use DSS audio interface and prepare for OMAP5 Ricardo Neri
2012-05-18 6:42 ` [PATCH 01/11] ASoC: OMAP: HDMI: Introduce codec Ricardo Neri
2012-05-18 16:32 ` Mark Brown
2012-05-18 16:55 ` Ricardo Neri
2012-05-18 6:42 ` [PATCH 02/11] ASoC: OMAP: HDMI: Update the platform device names Ricardo Neri
2012-05-18 6:42 ` Ricardo Neri [this message]
2012-05-18 20:46 ` does snd_pcm_info_get_sync work at all? Pierre-Louis Bossart
2012-05-18 21:21 ` Clemens Ladisch
2012-05-18 6:42 ` [PATCH 04/11] ASoC: OMAP: HDMI: Create a structure for private data of the CPU DAI Ricardo Neri
2012-05-18 6:42 ` [PATCH 05/11] ASoC: OMAP: HDMI: Use the DSS audio interface Ricardo Neri
2012-05-18 6:42 ` [PATCH 06/11] ASoC: OMAP: HDMI: Expand configuration of hw_params Ricardo Neri
2012-05-18 6:42 ` [PATCH 07/11] ASoC: OMAP: HDMI: Improve how the display state is verified Ricardo Neri
2012-05-18 6:42 ` [PATCH 08/11] ASoC: OMAP: HDMI: Expand capabilities of the HDMI DAI Ricardo Neri
2012-05-18 6:42 ` [PATCH 09/11] ASoC: OMAP: HDMI: Make build config options more generic Ricardo Neri
2012-05-18 6:42 ` [PATCH 10/11] ASoC: OMAP: HDMI: Make sound card naming " Ricardo Neri
2012-05-18 6:42 ` [PATCH 11/11] ASoC: OMAP: HDMI: Rename sound card source file Ricardo Neri
2012-05-18 16:33 ` [PATCH 00/11] ASoC: OMAP: HDMI: Use DSS audio interface and prepare for OMAP5 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337323363-11449-4-git-send-email-ricardo.neri@ti.com \
--to=ricardo.neri@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=s-guiriec@ti.com \
--cc=x0055901@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).