alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
	linux-ia64@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH] ia64: rename platform_name to ia64_platform_name
Date: Wed, 25 Jul 2012 01:18:39 -0700	[thread overview]
Message-ID: <1343204319.1693.6.camel@joe2Laptop> (raw)
In-Reply-To: <20120725080653.GA18233@localhost>

On Wed, 2012-07-25 at 16:06 +0800, Fengguang Wu wrote:
> The macro name is too generic and conflicts with
> snd_soc_dai_link.platform_name, which triggers lots of ALSA build errors.

Is platform_name particularly special?

Perhaps it's be better to rename all the other
platform_<foo> uses to ia64_platform_<foo>

[]

> diff --git a/arch/ia64/include/asm/machvec.h b/arch/ia64/include/asm/machvec.h
[]
> @@ -120,7 +120,7 @@ extern void machvec_tlb_migrate_finish (struct mm_struct *);
>  # ifdef MACHVEC_PLATFORM_HEADER
>  #  include MACHVEC_PLATFORM_HEADER
>  # else
> -#  define platform_name		ia64_mv.name
> +#  define ia64_platform_name	ia64_mv.name
>  #  define platform_setup	ia64_mv.setup
>  #  define platform_cpu_init	ia64_mv.cpu_init
>  #  define platform_irq_init	ia64_mv.irq_init

Maybe something like:

$ git ls-files arch/ia64 | \
  xargs sed -r -i 's/\bplatform_([a-z_]+)\b/ia64_platform_\1/g'


  reply	other threads:[~2012-07-25  8:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-25  8:06 [PATCH] ia64: rename platform_name to ia64_platform_name Fengguang Wu
2012-07-25  8:18 ` Joe Perches [this message]
2012-07-25 13:39   ` [PATCH] ia64: rename platform_* to ia64_platform_* Fengguang Wu
2012-07-25 18:37     ` Luck, Tony
2012-07-25 18:41       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343204319.1693.6.camel@joe2Laptop \
    --to=joe@perches.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).