From: Joe Perches <joe@perches.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Wu, Fengguang" <fengguang.wu@intel.com>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ia64: rename platform_* to ia64_platform_*
Date: Wed, 25 Jul 2012 11:41:58 -0700 [thread overview]
Message-ID: <1343241718.7045.3.camel@joe2Laptop> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F1937113E@ORSMSX104.amr.corp.intel.com>
On Wed, 2012-07-25 at 18:37 +0000, Luck, Tony wrote:
> >> Is platform_name particularly special?
>
> Yes. It is the symbol that is currently colliding with other subsystem namespace.
>
> >> Perhaps it's be better to rename all the other
> >> platform_<foo> uses to ia64_platform_<foo>
> >
> > That's good point in general, oh well I just wanted to make the minimal change..
>
> Following that logic there isn't anything special about symbols starting with
> "platform" ... and we should hunt down every global symbol in every architecture
> that is local to the architecture and replace it with $arch_$symbol.
>
> I think I'll just take the minimal patch to fix "platform_name" and continue to
> use a "fix as problems occur" algorithm to the namespace pollution problem.
That can lead to a lot of naming inconsistencies.
prev parent reply other threads:[~2012-07-25 18:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 8:06 [PATCH] ia64: rename platform_name to ia64_platform_name Fengguang Wu
2012-07-25 8:18 ` Joe Perches
2012-07-25 13:39 ` [PATCH] ia64: rename platform_* to ia64_platform_* Fengguang Wu
2012-07-25 18:37 ` Luck, Tony
2012-07-25 18:41 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343241718.7045.3.camel@joe2Laptop \
--to=joe@perches.com \
--cc=alsa-devel@alsa-project.org \
--cc=fengguang.wu@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).