From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] ia64: rename platform_* to ia64_platform_* Date: Wed, 25 Jul 2012 11:41:58 -0700 Message-ID: <1343241718.7045.3.camel@joe2Laptop> References: <20120725080653.GA18233@localhost> <1343204319.1693.6.camel@joe2Laptop> <20120725133950.GA30512@localhost> <3908561D78D1C84285E8C5FCA982C28F1937113E@ORSMSX104.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from labridge.com (perches-mx.perches.com [206.117.179.246]) by alsa0.perex.cz (Postfix) with ESMTP id 32E5B265365 for ; Wed, 25 Jul 2012 20:41:57 +0200 (CEST) In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F1937113E@ORSMSX104.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Luck, Tony" Cc: "alsa-devel@alsa-project.org" , "Wu, Fengguang" , "linux-ia64@vger.kernel.org" , LKML List-Id: alsa-devel@alsa-project.org On Wed, 2012-07-25 at 18:37 +0000, Luck, Tony wrote: > >> Is platform_name particularly special? > > Yes. It is the symbol that is currently colliding with other subsystem namespace. > > >> Perhaps it's be better to rename all the other > >> platform_ uses to ia64_platform_ > > > > That's good point in general, oh well I just wanted to make the minimal change.. > > Following that logic there isn't anything special about symbols starting with > "platform" ... and we should hunt down every global symbol in every architecture > that is local to the architecture and replace it with $arch_$symbol. > > I think I'll just take the minimal patch to fix "platform_name" and continue to > use a "fix as problems occur" algorithm to the namespace pollution problem. That can lead to a lot of naming inconsistencies.