From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: STEricsson_nomadik_linux@list.st.com,
linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se,
ola.o.lilja@stericsson.com, sameo@linux.intel.com,
alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
lrg@ti.com, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 1/7] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too
Date: Fri, 27 Jul 2012 13:38:48 +0100 [thread overview]
Message-ID: <1343392734-11805-2-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1343392734-11805-1-git-send-email-lee.jones@linaro.org>
If a list of widgets is provided and one of them fails to be added as
a control, the present semantics fail all subsequent widgets. A better
solution would be to only fail that widget, but pursue in attempting
to add the rest of the list.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
sound/soc/soc-dapm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index eded657..7d9c154 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3095,8 +3095,6 @@ int snd_soc_dapm_new_controls(struct snd_soc_dapm_context *dapm,
dev_err(dapm->dev,
"ASoC: Failed to create DAPM control %s\n",
widget->name);
- ret = -ENOMEM;
- break;
}
widget++;
}
--
1.7.9.5
next prev parent reply other threads:[~2012-07-27 12:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 12:38 [PATCH 0/7] Bugfixes and clean-ups bound for the v3.6 RCs Lee Jones
2012-07-27 12:38 ` Lee Jones [this message]
2012-07-29 20:25 ` [PATCH 1/7] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too Mark Brown
2012-07-27 12:38 ` [PATCH 2/7] ASoC: ab8500: Inform SoC Core that we have our own I/O arrangements Lee Jones
2012-07-27 12:38 ` [PATCH 3/7] mfd: db8500-prcmu: Ensure AB8500 platform data is passed through MFD Core Lee Jones
2012-07-27 13:36 ` Samuel Ortiz
2012-07-27 12:38 ` [PATCH 4/7] mfd: ab8500-core: Apply the AB8500 CODEC's compatible string to its MFD cell Lee Jones
2012-07-27 13:36 ` Samuel Ortiz
2012-07-29 20:28 ` Mark Brown
2012-07-30 13:24 ` Samuel Ortiz
2012-09-14 16:05 ` Lee Jones
2012-09-19 11:28 ` Samuel Ortiz
2012-07-27 12:38 ` [PATCH 5/7] ARM: ux500: Remove unused snowball_of_platform_devs struct Lee Jones
2012-07-27 12:38 ` [PATCH 6/7] ARM: ux500: Fix merge error, so such struct 'snd_soc_u8500' Lee Jones
2012-07-27 12:38 ` [PATCH 7/7] ARM: ux500: Ensure probing of Audio devices when Device Tree is enabled Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343392734-11805-2-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=ola.o.lilja@stericsson.com \
--cc=olalilja@yahoo.se \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).