From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: tlv320aic3x: Fix mono
Date: Sat, 26 Jan 2013 15:17:01 +0100 (CET) [thread overview]
Message-ID: <1343658253.242147.1359209821129.JavaMail.root@advansee.com> (raw)
In-Reply-To: <20130126085512.GC30594@opensource.wolfsonmicro.com>
On Saturday, January 26, 2013 9:55:14 AM, Mark Brown wrote:
> On Fri, Jan 25, 2013 at 06:19:20PM +0100, Benoît Thébaudeau wrote:
> > The TLV320AIC3x DAI supports only stereo. This patch fixes mono support for
> > this
> > codec by allowing only stereo at codec level.
>
> So, this doesn't actually fix mono - it removes support for it.
Yes, for this driver, but this fixes mono for the whole system, meaning that
e.g. it fixes mono playback support with players like MPlayer. I will reword if
you prefer.
> It's a
> bit surprising that this is a requirement actually, the device seems to
> support DSP modes which usually do mono totally happily (I2S style modes
> have problems due to the clocking). I'd like to see some confirmation
> that there's not some other issue in your system...
I've only tested with I²S (imx-ssi). But for all the available DAI modes, the
data sheet gives the encoding for both stereo channels (from p. 21), and nowhere
it says that mono is an option for DAI:
http://www.ti.com/lit/ds/symlink/tlv320aic3104.pdf
I will retest with DSP modes if you prefer.
The idea was the same as for this commit:
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=37f45cc54cb03cac4a6b865b32bc705bb0cb1d29
Even though the MC13783 only supports I²S and MSB justified modes, and there may
be an issue specific to it:
http://cache.freescale.com/files/rf_if/doc/data_sheet/MC13783.pdf?pspll=1
Best regards,
Benoît
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2013-01-26 14:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 17:19 [PATCH] ASoC: tlv320aic3x: Fix mono Benoît Thébaudeau
2013-01-26 8:55 ` Mark Brown
2013-01-26 14:17 ` Benoît Thébaudeau [this message]
2013-01-27 2:58 ` Mark Brown
2013-01-28 21:03 ` Benoît Thébaudeau
2013-01-29 2:01 ` Mark Brown
2013-01-29 20:40 ` Benoît Thébaudeau
2013-01-30 2:11 ` Mark Brown
2013-01-30 11:17 ` Benoît Thébaudeau
2013-01-29 20:31 ` [PATCH v2] ASoC: tlv320aic3x: Remove mono support Benoît Thébaudeau
2013-01-30 2:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343658253.242147.1359209821129.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=fabio.estevam@freescale.com \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).