alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Russell King <rmk+kernel@arm.linux.org.uk>,
	Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: Liam Girdwood <lrg@ti.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: [RFC update 2/2] ASoC: omap-pcm: Do not check DMA sync_mode
Date: Tue,  4 Sep 2012 15:08:02 +0300	[thread overview]
Message-ID: <1346760482-12794-3-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1346760482-12794-1-git-send-email-peter.ujfalusi@ti.com>

OMAP dmaengine now supports element mode also in cyclic DMA so we do not
need to block non PACKET modes.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 sound/soc/omap/omap-pcm.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
index 50ae048..0f88db3 100644
--- a/sound/soc/omap/omap-pcm.c
+++ b/sound/soc/omap/omap-pcm.c
@@ -32,7 +32,6 @@
 #include <sound/pcm_params.h>
 #include <sound/soc.h>
 
-#include <plat/dma.h> /* needed just for OMAP_DMA_SYNC_PACKET */
 #include "omap-pcm.h"
 
 static const struct snd_pcm_hardware omap_pcm_hardware = {
@@ -83,15 +82,6 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream,
 		return 0;
 	prtd->dma_data = dma_data;
 
-	/*
-	 * This is the only parameter we don't handle with DMA
-	 * engine - so we insist on OMAP_DMA_SYNC_PACKET here.
-	 */
-	if (dma_data->sync_mode != OMAP_DMA_SYNC_PACKET) {
-		pr_warn("ALSA: omap-dma: DMA using non-packet mode?\n");
-		return -EINVAL;
-	}
-
 	req = dma_data->dma_req;
 	err = snd_dmaengine_pcm_open(substream, omap_dma_filter_fn, &req);
 	if (err)
-- 
1.7.12


  parent reply	other threads:[~2012-09-04 12:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-03 16:58 [RFC 0/3] Initial stab at converting OMAP ASoC support to DMA engine Russell King - ARM Linux
2012-09-03 16:59 ` [RFC 1/3] ASoC: dmaengine: Don't use runtime private data for dmaengine data Liam Girdwood
2012-09-03 20:25   ` Lars-Peter Clausen
2012-09-03 20:43     ` Russell King - ARM Linux
2012-09-03 20:59       ` Lars-Peter Clausen
2012-09-04 13:14         ` [alsa-devel] " Takashi Iwai
2012-09-04 13:26           ` Peter Ujfalusi
2012-09-04 18:14             ` Russell King - ARM Linux
2012-09-03 16:59 ` [RFC 2/3] Fix "ASoC: dmaengine: Don't use runtime private data for dmaengine data" Russell King
2012-09-03 16:59 ` [RFC 3/3] ASoC: first stab at converting OMAP PCM driver to use dmaengine Russell King
2012-09-04 12:08   ` [RFC update 0/2] dmaengine/ASoC: omap: Enable element mode in cyclic DMA Peter Ujfalusi
2012-09-04 12:08     ` [RFC update 1/2] dmaengine: omap: Support for " Peter Ujfalusi
2012-09-04 12:08     ` Peter Ujfalusi [this message]
2012-09-04 22:37     ` [RFC update 0/2] dmaengine/ASoC: omap: Enable " Janusz Krzysztofik
2012-09-09 19:57     ` Janusz Krzysztofik
2012-09-10  8:21       ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346760482-12794-3-git-send-email-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=jarkko.nikula@bitmer.com \
    --cc=jkrzyszt@tis.icnet.pl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).