alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Tanu Kaskinen <tanuk@iki.fi>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [RFC] Channel mapping API (take 2)
Date: Wed, 05 Sep 2012 09:00:12 +0300	[thread overview]
Message-ID: <1346824812.3629.29.camel@laptop> (raw)
In-Reply-To: <s5hhard23jb.wl%tiwai@suse.de>

On Tue, 2012-09-04 at 17:47 +0200, Takashi Iwai wrote:
> The rest aren't so much changed.  Only slight bug fixes.

I have a couple of comments about "the rest". I haven't been following
the development of the channel map API very closely, so I'm relying on
the pcm.h file only.


/** channel map list type */
enum snd_pcm_chmap_type {
	SND_CHMAP_NONE = 0,	/** unspecified channel position */
	SND_CHMAP_FIXED,	/** fixed channel position */
	SND_CHMAP_VAR,		/** freely swappable channel position */
	SND_CHMAP_PAIRED,	/** pair-wise swappable channel position */
};

It's not clear to me what the VAR and PAIRED types actually mean. It
would be nice to explain in more detail the concepts in the header.


The snd_pcm_chmap_position enum doesn't contain an entry for mono. I
think it would be a useful channel to have. Up/downmixing decisions may
be different with mono than, for example, a single channel declared as
front left.

-- 
Tanu

  reply	other threads:[~2012-09-05  6:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-04 15:47 [RFC] Channel mapping API (take 2) Takashi Iwai
2012-09-05  6:00 ` Tanu Kaskinen [this message]
2012-09-05  6:17   ` Takashi Iwai
2012-09-05  6:38     ` Tanu Kaskinen
2012-09-05  6:49 ` David Henningsson
2012-09-05  6:59   ` Takashi Iwai
2012-09-05  8:32 ` David Henningsson
2012-09-05 10:34   ` Takashi Iwai
2012-09-06 11:47 ` Raymond Yau
2012-09-06 11:56   ` Takashi Iwai
2012-09-07  9:16 ` Tanu Kaskinen
2012-09-07  9:43   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346824812.3629.29.camel@laptop \
    --to=tanuk@iki.fi \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).