* [PATCH 1/3] ASoC: Revert "ASoC: mc13783: Provide codec->control_data"
@ 2012-09-10 16:10 Fabio Estevam
2012-09-10 16:10 ` [PATCH 2/3] ASoC: Revert "ASoC: ab8500: Inform SoC Core that we have our own I/O arrangements" Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2012-09-10 16:10 UTC (permalink / raw)
To: broonie; +Cc: Fabio Estevam, manuel.lauss, lee.jones, alsa-devel
Since commit 98d3088e5 (SoC: core: Fix check before defaulting to regmap)
, it is not necessary to provide codec->control_data anymore.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
sound/soc/codecs/mc13783.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/codecs/mc13783.c b/sound/soc/codecs/mc13783.c
index 8def29a..bc95599 100644
--- a/sound/soc/codecs/mc13783.c
+++ b/sound/soc/codecs/mc13783.c
@@ -585,8 +585,6 @@ static int mc13783_probe(struct snd_soc_codec *codec)
{
struct mc13783_priv *priv = snd_soc_codec_get_drvdata(codec);
- codec->control_data = priv->mc13xxx;
-
mc13xxx_lock(priv->mc13xxx);
/* these are the reset values */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/3] ASoC: Revert "ASoC: ab8500: Inform SoC Core that we have our own I/O arrangements" 2012-09-10 16:10 [PATCH 1/3] ASoC: Revert "ASoC: mc13783: Provide codec->control_data" Fabio Estevam @ 2012-09-10 16:10 ` Fabio Estevam 2012-09-10 16:10 ` [PATCH 3/3] Revert "ASoC: AC97 doesn't use regmap by default" Fabio Estevam 2012-09-11 0:21 ` [PATCH 1/3] ASoC: Revert "ASoC: mc13783: Provide codec->control_data" Mark Brown 2 siblings, 0 replies; 4+ messages in thread From: Fabio Estevam @ 2012-09-10 16:10 UTC (permalink / raw) To: broonie; +Cc: Fabio Estevam, manuel.lauss, lee.jones, alsa-devel Since commit 98d3088e5 (SoC: core: Fix check before defaulting to regmap) , it is not necessary to provide codec->control_data anymore. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- sound/soc/codecs/ab8500-codec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c index 3f46bff..2c1c252 100644 --- a/sound/soc/codecs/ab8500-codec.c +++ b/sound/soc/codecs/ab8500-codec.c @@ -2404,9 +2404,6 @@ static int ab8500_codec_probe(struct snd_soc_codec *codec) dev_dbg(dev, "%s: Enter.\n", __func__); - /* Inform SoC Core that we have our own I/O arrangements. */ - codec->control_data = (void *)true; - /* Setup AB8500 according to board-settings */ pdata = dev_get_platdata(dev->parent); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] Revert "ASoC: AC97 doesn't use regmap by default" 2012-09-10 16:10 [PATCH 1/3] ASoC: Revert "ASoC: mc13783: Provide codec->control_data" Fabio Estevam 2012-09-10 16:10 ` [PATCH 2/3] ASoC: Revert "ASoC: ab8500: Inform SoC Core that we have our own I/O arrangements" Fabio Estevam @ 2012-09-10 16:10 ` Fabio Estevam 2012-09-11 0:21 ` [PATCH 1/3] ASoC: Revert "ASoC: mc13783: Provide codec->control_data" Mark Brown 2 siblings, 0 replies; 4+ messages in thread From: Fabio Estevam @ 2012-09-10 16:10 UTC (permalink / raw) To: broonie; +Cc: Fabio Estevam, manuel.lauss, lee.jones, alsa-devel Since commit 98d3088e5 (SoC: core: Fix check before defaulting to regmap) , it is not necessary to provide codec->control_data anymore. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- sound/soc/codecs/ad1980.c | 1 - sound/soc/codecs/stac9766.c | 1 - sound/soc/codecs/wm9712.c | 1 - sound/soc/codecs/wm9713.c | 1 - 4 files changed, 4 deletions(-) diff --git a/sound/soc/codecs/ad1980.c b/sound/soc/codecs/ad1980.c index 11b1b71..8c39ddd 100644 --- a/sound/soc/codecs/ad1980.c +++ b/sound/soc/codecs/ad1980.c @@ -186,7 +186,6 @@ static int ad1980_soc_probe(struct snd_soc_codec *codec) printk(KERN_INFO "AD1980 SoC Audio Codec\n"); - codec->control_data = codec; /* we don't use regmap! */ ret = snd_soc_new_ac97_codec(codec, &soc_ac97_ops, 0); if (ret < 0) { printk(KERN_ERR "ad1980: failed to register AC97 codec\n"); diff --git a/sound/soc/codecs/stac9766.c b/sound/soc/codecs/stac9766.c index 33c0f3d..982e437 100644 --- a/sound/soc/codecs/stac9766.c +++ b/sound/soc/codecs/stac9766.c @@ -340,7 +340,6 @@ static int stac9766_codec_probe(struct snd_soc_codec *codec) printk(KERN_INFO "STAC9766 SoC Audio Codec %s\n", STAC9766_VERSION); - codec->control_data = codec; /* we don't use regmap! */ ret = snd_soc_new_ac97_codec(codec, &soc_ac97_ops, 0); if (ret < 0) goto codec_err; diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c index 1992a62..4dd73ea 100644 --- a/sound/soc/codecs/wm9712.c +++ b/sound/soc/codecs/wm9712.c @@ -635,7 +635,6 @@ static int wm9712_soc_probe(struct snd_soc_codec *codec) { int ret = 0; - codec->control_data = codec; /* we don't use regmap! */ ret = snd_soc_new_ac97_codec(codec, &soc_ac97_ops, 0); if (ret < 0) { printk(KERN_ERR "wm9712: failed to register AC97 codec\n"); diff --git a/sound/soc/codecs/wm9713.c b/sound/soc/codecs/wm9713.c index d0b8a32..3eb19fb 100644 --- a/sound/soc/codecs/wm9713.c +++ b/sound/soc/codecs/wm9713.c @@ -1196,7 +1196,6 @@ static int wm9713_soc_probe(struct snd_soc_codec *codec) if (wm9713 == NULL) return -ENOMEM; snd_soc_codec_set_drvdata(codec, wm9713); - codec->control_data = wm9713; /* we don't use regmap! */ ret = snd_soc_new_ac97_codec(codec, &soc_ac97_ops, 0); if (ret < 0) -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] ASoC: Revert "ASoC: mc13783: Provide codec->control_data" 2012-09-10 16:10 [PATCH 1/3] ASoC: Revert "ASoC: mc13783: Provide codec->control_data" Fabio Estevam 2012-09-10 16:10 ` [PATCH 2/3] ASoC: Revert "ASoC: ab8500: Inform SoC Core that we have our own I/O arrangements" Fabio Estevam 2012-09-10 16:10 ` [PATCH 3/3] Revert "ASoC: AC97 doesn't use regmap by default" Fabio Estevam @ 2012-09-11 0:21 ` Mark Brown 2 siblings, 0 replies; 4+ messages in thread From: Mark Brown @ 2012-09-11 0:21 UTC (permalink / raw) To: Fabio Estevam; +Cc: manuel.lauss, lee.jones, alsa-devel On Mon, Sep 10, 2012 at 01:10:08PM -0300, Fabio Estevam wrote: > Since commit 98d3088e5 (SoC: core: Fix check before defaulting to regmap) > , it is not necessary to provide codec->control_data anymore. Applied all, thanks. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-11 0:21 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-09-10 16:10 [PATCH 1/3] ASoC: Revert "ASoC: mc13783: Provide codec->control_data" Fabio Estevam 2012-09-10 16:10 ` [PATCH 2/3] ASoC: Revert "ASoC: ab8500: Inform SoC Core that we have our own I/O arrangements" Fabio Estevam 2012-09-10 16:10 ` [PATCH 3/3] Revert "ASoC: AC97 doesn't use regmap by default" Fabio Estevam 2012-09-11 0:21 ` [PATCH 1/3] ASoC: Revert "ASoC: mc13783: Provide codec->control_data" Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).