* [PATCH] ALSA: hda - fix indices on boost volume on Conexant
@ 2012-10-02 8:14 David Henningsson
2012-10-08 8:17 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: David Henningsson @ 2012-10-02 8:14 UTC (permalink / raw)
To: alsa-devel, tiwai; +Cc: David Henningsson, 1059523
After the recent patch "ALSA: hda - use both input paths on Conexant
auto parser" suddenly we can have more than one "Mic Boost", this
happened on Acer Aspire One 722. Therefore we must add the possibility
to put an index on this "Mic Boost" just as we do for the other
"Mic Boost" earlier in the same function.
BugLink: https://bugs.launchpad.net/bugs/1059523
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
sound/pci/hda/patch_conexant.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index c03d3b8..c11ad8a 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -4273,7 +4273,7 @@ static int cx_auto_add_boost_volume(struct hda_codec *codec, int idx,
if (get_wcaps(codec, mux) & AC_WCAP_OUT_AMP) {
spec->imux_info[idx].boost = mux;
- return cx_auto_add_volume(codec, label, " Boost", 0,
+ return cx_auto_add_volume(codec, label, " Boost", cidx,
mux, HDA_OUTPUT);
}
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: hda - fix indices on boost volume on Conexant
2012-10-02 8:14 [PATCH] ALSA: hda - fix indices on boost volume on Conexant David Henningsson
@ 2012-10-08 8:17 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2012-10-08 8:17 UTC (permalink / raw)
To: David Henningsson; +Cc: alsa-devel, 1059523
At Tue, 2 Oct 2012 10:14:23 +0200,
David Henningsson wrote:
>
> After the recent patch "ALSA: hda - use both input paths on Conexant
> auto parser" suddenly we can have more than one "Mic Boost", this
> happened on Acer Aspire One 722. Therefore we must add the possibility
> to put an index on this "Mic Boost" just as we do for the other
> "Mic Boost" earlier in the same function.
>
> BugLink: https://bugs.launchpad.net/bugs/1059523
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Applied, thanks.
Takashi
> ---
> sound/pci/hda/patch_conexant.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> index c03d3b8..c11ad8a 100644
> --- a/sound/pci/hda/patch_conexant.c
> +++ b/sound/pci/hda/patch_conexant.c
> @@ -4273,7 +4273,7 @@ static int cx_auto_add_boost_volume(struct hda_codec *codec, int idx,
>
> if (get_wcaps(codec, mux) & AC_WCAP_OUT_AMP) {
> spec->imux_info[idx].boost = mux;
> - return cx_auto_add_volume(codec, label, " Boost", 0,
> + return cx_auto_add_volume(codec, label, " Boost", cidx,
> mux, HDA_OUTPUT);
> }
> return 0;
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-08 8:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-02 8:14 [PATCH] ALSA: hda - fix indices on boost volume on Conexant David Henningsson
2012-10-08 8:17 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).