alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: fix documentation in soc-jack
@ 2012-10-02 12:08 Peter Meerwald
  2012-10-09  6:39 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Meerwald @ 2012-10-02 12:08 UTC (permalink / raw)
  To: alsa-devel; +Cc: broonie, lrg, Peter Meerwald

From: Peter Meerwald <p.meerwald@bct-electronic.com>

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
 sound/soc/soc-jack.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c
index 0c17293..b24cd53 100644
--- a/sound/soc/soc-jack.c
+++ b/sound/soc/soc-jack.c
@@ -22,7 +22,7 @@
 
 /**
  * snd_soc_jack_new - Create a new jack
- * @card:  ASoC card
+ * @codec: ASoC codec
  * @id:    an identifying string for this jack
  * @type:  a bitmask of enum snd_jack_type values that can be detected by
  *         this jack
@@ -139,12 +139,13 @@ EXPORT_SYMBOL_GPL(snd_soc_jack_add_zones);
 
 /**
  * snd_soc_jack_get_type - Based on the mic bias value, this function returns
- * the type of jack from the zones delcared in the jack type
+ * the type of jack from the zones declared in the jack type
  *
+ * @jack:  ASoC jack
  * @micbias_voltage:  mic bias voltage at adc channel when jack is plugged in
  *
  * Based on the mic bias value passed, this function helps identify
- * the type of jack from the already delcared jack zones
+ * the type of jack from the already declared jack zones
  */
 int snd_soc_jack_get_type(struct snd_soc_jack *jack, int micbias_voltage)
 {
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: fix documentation in soc-jack
  2012-10-02 12:08 [PATCH] ASoC: fix documentation in soc-jack Peter Meerwald
@ 2012-10-09  6:39 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-10-09  6:39 UTC (permalink / raw)
  To: Peter Meerwald; +Cc: alsa-devel, lrg

On Tue, Oct 02, 2012 at 02:08:19PM +0200, Peter Meerwald wrote:
> From: Peter Meerwald <p.meerwald@bct-electronic.com>
> 
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>

Applied, thanks.  It would be helpful if your changelogs were, uh,
better documented :) - it does make life much easier when reviewing if
you've got an idea as to what's in the patch when you start reading it.

Something like "fixes spelling mistakes and mislabelled parameters" for
example.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-09  6:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-02 12:08 [PATCH] ASoC: fix documentation in soc-jack Peter Meerwald
2012-10-09  6:39 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).