From: Adrian Knoth <adi@drcomp.erfurt.thur.de>
To: patch@alsa-project.org
Cc: Adrian Knoth <adi@drcomp.erfurt.thur.de>,
alsa-devel@alsa-project.org, andre.schramm@iosono-sound.com
Subject: [PATCH 3/9] ALSA: hdspm - Fix sync check reporting on all RME HDSPM cards
Date: Fri, 19 Oct 2012 17:42:24 +0200 [thread overview]
Message-ID: <1350661350-5000-4-git-send-email-adi@drcomp.erfurt.thur.de> (raw)
In-Reply-To: <1350661350-5000-1-git-send-email-adi@drcomp.erfurt.thur.de>
Due to missing breaks and the resulting fall-through, card subtype
selection was effectively missing, thus causing the wrong sync check
functions to be called.
Signed-off-by: Adrian Knoth <adi@drcomp.erfurt.thur.de>
diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c
index 1131a8a..81d83fa 100644
--- a/sound/pci/rme9652/hdspm.c
+++ b/sound/pci/rme9652/hdspm.c
@@ -3959,6 +3959,7 @@ static int snd_hdspm_get_sync_check(struct snd_kcontrol *kcontrol,
default:
val = hdspm_s1_sync_check(hdspm, ucontrol->id.index-1);
}
+ break;
case AIO:
switch (kcontrol->private_value) {
@@ -3971,6 +3972,7 @@ static int snd_hdspm_get_sync_check(struct snd_kcontrol *kcontrol,
default:
val = hdspm_s1_sync_check(hdspm, ucontrol->id.index-1);
}
+ break;
case MADI:
switch (kcontrol->private_value) {
@@ -3983,6 +3985,7 @@ static int snd_hdspm_get_sync_check(struct snd_kcontrol *kcontrol,
case 3: /* SYNC_IN */
val = hdspm_sync_in_sync_check(hdspm); break;
}
+ break;
case MADIface:
val = hdspm_madi_sync_check(hdspm); /* MADI */
@@ -4000,6 +4003,7 @@ static int snd_hdspm_get_sync_check(struct snd_kcontrol *kcontrol,
val = hdspm_aes_sync_check(hdspm,
kcontrol->private_value-1);
}
+ break;
}
--
1.7.10.4
next prev parent reply other threads:[~2012-10-19 15:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 15:42 [PATCH 0/9] Fixes for RME MADI cards Adrian Knoth
2012-10-19 15:42 ` [PATCH 1/9] ALSA: hdspm - Allow DDS/Varispeed to be set from userspace Adrian Knoth
2012-10-19 20:48 ` Takashi Iwai
2012-10-20 8:35 ` Adrian Knoth
2012-10-20 8:46 ` Takashi Iwai
2012-10-19 15:42 ` [PATCH 2/9] ALSA: hdspm - Report external rate in slave mode on PCI MADI Adrian Knoth
2012-10-19 15:42 ` Adrian Knoth [this message]
2012-10-19 15:42 ` [PATCH 4/9] ALSA: hdspm - Fix reported autosync_sample_rate Adrian Knoth
2012-10-19 15:42 ` [PATCH 5/9] ALSA: hdspm - Also report autosync_sample_rate on MADI and MADIface Adrian Knoth
2012-10-20 8:46 ` Takashi Iwai
2012-10-19 15:42 ` [PATCH 6/9] ALSA: hdspm - Fix sync_in reporting on RME MADI cards Adrian Knoth
2012-10-19 15:42 ` [PATCH 7/9] ALSA: hdspm - Fix sync_in detection on AES/AES32 Adrian Knoth
2012-10-19 15:42 ` [PATCH 8/9] ALSA: hdspm - Fix typo in kcontrol element on RME MADI cards Adrian Knoth
2012-10-19 15:42 ` [PATCH 9/9] ALSA: hdspm - Fix coding style in CTL_ELEM macros Adrian Knoth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350661350-5000-4-git-send-email-adi@drcomp.erfurt.thur.de \
--to=adi@drcomp.erfurt.thur.de \
--cc=alsa-devel@alsa-project.org \
--cc=andre.schramm@iosono-sound.com \
--cc=patch@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).