From: Eldad Zack <eldad@fogrefinery.com>
To: Takashi Iwai <tiwai@suse.de>, Daniel Mack <zonque@gmail.com>,
Felix Homann <linuxaudio@showlabor.de>,
Clemens Ladisch <clemens@ladisch.de>,
alsa-devel@alsa-project.org
Cc: Grant Diffey <gdiffey@gmail.com>,
George Willian Condomitti <georgecondomitti@gmail.com>,
Chris Cavey <chris-alsa@rauros.net>,
Eldad Zack <eldad@fogrefinery.com>
Subject: [FT C400, PATCH RFC, v3 1/9] usb-audio: replace hardcoded value with const
Date: Tue, 27 Nov 2012 17:00:50 +0100 [thread overview]
Message-ID: <1354032058-668-2-git-send-email-eldad@fogrefinery.com> (raw)
In-Reply-To: <1354032058-668-1-git-send-email-eldad@fogrefinery.com>
In this context, 0x01 is USB_ENDPOINT_XFER_ISOC.
Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
---
sound/usb/pcm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index ef6fa24..ff8cbbf 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -381,7 +381,7 @@ static int set_format(struct snd_usb_substream *subs, struct audioformat *fmt)
/* ... and check descriptor size before accessing bSynchAddress
because there is a version of the SB Audigy 2 NX firmware lacking
the audio fields in the endpoint descriptors */
- if ((get_endpoint(alts, 1)->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) != 0x01 ||
+ if ((get_endpoint(alts, 1)->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) != USB_ENDPOINT_XFER_ISOC ||
(get_endpoint(alts, 1)->bLength >= USB_DT_ENDPOINT_AUDIO_SIZE &&
get_endpoint(alts, 1)->bSynchAddress != 0 &&
!implicit_fb)) {
--
1.7.8.6
next prev parent reply other threads:[~2012-11-27 16:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 16:00 [FT C400,PATCH RFC,v3 0/9] M-Audio Fast Track C400 Eldad Zack
2012-11-27 16:00 ` Eldad Zack [this message]
2012-11-27 16:00 ` [FT C400, PATCH RFC, v3 2/9] usb-audio: use sender stride for implicit feedback Eldad Zack
2012-11-27 16:00 ` [FT C400, PATCH RFC, v3 3/9] usb-audio: add control index offset Eldad Zack
2012-11-27 16:00 ` [FT C400, PATCH RFC, v3 4/9] usb-audio: skip UAC2 EFFECT_UNIT Eldad Zack
2012-11-27 16:00 ` [FT C400, PATCH RFC, v3 5/9] usb-audio: parameterize FTU effect unit control Eldad Zack
2012-11-27 16:00 ` [FT C400, PATCH RFC, v3 6/9] usb-audio: M-Audio Fast Track C400 quirks table Eldad Zack
2012-11-27 16:11 ` Clemens Ladisch
2012-11-27 16:44 ` Eldad Zack
2012-11-28 10:20 ` Takashi Iwai
2012-11-27 16:00 ` [FT C400, PATCH RFC, v3 7/9] usb-audio: Fast Track C400 mixer ranges Eldad Zack
2012-11-27 16:12 ` Clemens Ladisch
2012-11-27 17:44 ` Eldad Zack
2012-11-27 16:00 ` [FT C400, PATCH RFC, v3 8/9] usb-audio: Fast Track C400 mixer controls Eldad Zack
2012-11-27 16:00 ` [FT C400, PATCH RFC, v3 9/9] usb-audio: FT C400 sync playback EP to capture EP Eldad Zack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354032058-668-2-git-send-email-eldad@fogrefinery.com \
--to=eldad@fogrefinery.com \
--cc=alsa-devel@alsa-project.org \
--cc=chris-alsa@rauros.net \
--cc=clemens@ladisch.de \
--cc=gdiffey@gmail.com \
--cc=georgecondomitti@gmail.com \
--cc=linuxaudio@showlabor.de \
--cc=tiwai@suse.de \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox