From: Alexander Sverdlin <subaparts@yandex.ru>
To: Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
lrg@ti.com
Subject: Re: [PATCH] ALSA: ASoC: cs4271: add optional soft reset workaround
Date: Mon, 10 Dec 2012 21:58:58 +0100 [thread overview]
Message-ID: <1355173138.30925.2.camel@r60e> (raw)
In-Reply-To: <1355131804-22707-1-git-send-email-zonque@gmail.com>
Hi!
On Mon, 2012-12-10 at 10:30 +0100, Daniel Mack wrote:
> The CS4271 requires its LRCLK and MCLK to be stable before its RESET
> line is de-asserted. That also means that clocks cannot be changed
> without putting the chip back into hardware reset, which also requires
> a complete re-initialization of all registers.
>
> One (undocumented) workaround is to assert and de-assert the PDN bit
> in the MODE2 register.
>
> This patch adds a new flag to both the DT bindings as well as to the
> platform data to enable that workaround.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
Looks good to me.
Acked-by: Alexander Sverdlin <subaparts@yandex.ru>
--
Regards,
Alexander.
next prev parent reply other threads:[~2012-12-10 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 9:30 [PATCH] ALSA: ASoC: cs4271: add optional soft reset workaround Daniel Mack
2012-12-10 20:58 ` Alexander Sverdlin [this message]
2012-12-24 15:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355173138.30925.2.camel@r60e \
--to=subaparts@yandex.ru \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).