alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
Cc: alsa-devel@alsa-project.org,
	"Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH v2] ASoC: tlv320aic3x: Remove mono support
Date: Tue, 29 Jan 2013 21:31:48 +0100	[thread overview]
Message-ID: <1359491508-22518-1-git-send-email-benoit.thebaudeau@advansee.com> (raw)
In-Reply-To: <1359134360-25482-1-git-send-email-benoit.thebaudeau@advansee.com>

Playing a mono stream on the TLV320AIC3x results in too fast playback rate.

Remove mono support so that mono streams can be played correctly on this codec.

Tested with imx-ssi (i.MX25) and TLV320AIC3104.

Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: <alsa-devel@alsa-project.org>
Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
---
Changes for v2:
 - Reword patch description as mono removal rather than as mono fix.
---
 sound/soc/codecs/tlv320aic3x.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index 5708a97..4989143 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -1210,13 +1210,13 @@ static struct snd_soc_dai_driver aic3x_dai = {
 	.name = "tlv320aic3x-hifi",
 	.playback = {
 		.stream_name = "Playback",
-		.channels_min = 1,
+		.channels_min = 2,
 		.channels_max = 2,
 		.rates = AIC3X_RATES,
 		.formats = AIC3X_FORMATS,},
 	.capture = {
 		.stream_name = "Capture",
-		.channels_min = 1,
+		.channels_min = 2,
 		.channels_max = 2,
 		.rates = AIC3X_RATES,
 		.formats = AIC3X_FORMATS,},
-- 
1.7.10.4

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2013-01-29 20:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-25 17:19 [PATCH] ASoC: tlv320aic3x: Fix mono Benoît Thébaudeau
2013-01-26  8:55 ` Mark Brown
2013-01-26 14:17   ` Benoît Thébaudeau
2013-01-27  2:58     ` Mark Brown
2013-01-28 21:03       ` Benoît Thébaudeau
2013-01-29  2:01         ` Mark Brown
2013-01-29 20:40           ` Benoît Thébaudeau
2013-01-30  2:11             ` Mark Brown
2013-01-30 11:17               ` Benoît Thébaudeau
2013-01-29 20:31 ` Benoît Thébaudeau [this message]
2013-01-30  2:15   ` [PATCH v2] ASoC: tlv320aic3x: Remove mono support Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359491508-22518-1-git-send-email-benoit.thebaudeau@advansee.com \
    --to=benoit.thebaudeau@advansee.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).