From: allan@allanwirth.com
To: patch@alsa-project.org
Cc: alsa-devel@alsa-project.org, Allan Wirth <allan@allanwirth.com>
Subject: [PATCH - my module 1/1] Fix a memory access violation resulting from improper error propogation.
Date: Thu, 31 Jan 2013 13:55:33 -0500 [thread overview]
Message-ID: <1359658533-23170-1-git-send-email-allan@allanwirth.com> (raw)
From: Allan Wirth <allan@allanwirth.com>
Fixes an issue where a variable is used undeclared, which can cause seg
faults on some systems if the configuration file is not formatted
properly.
Signed-off-by: Allan Wirth <allan@allanwirth.com>
diff --git a/src/conf.c b/src/conf.c
index ecaa339..4ba5863 100644
--- a/src/conf.c
+++ b/src/conf.c
@@ -3530,7 +3530,7 @@ int snd_config_hook_load(snd_config_t *root, snd_config_t *config, snd_config_t
if (err < 0)
goto _err;
}
- } else if (config_file_open(root, fi[idx].name) < 0)
+ } else if ((err = config_file_open(root, fi[idx].name)) < 0)
goto _err;
}
*dst = NULL;
--
1.7.10.4
next reply other threads:[~2013-01-31 18:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 18:55 allan [this message]
2013-02-01 7:16 ` [PATCH - my module 1/1] Fix a memory access violation resulting from improper error propogation Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359658533-23170-1-git-send-email-allan@allanwirth.com \
--to=allan@allanwirth.com \
--cc=alsa-devel@alsa-project.org \
--cc=patch@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).