From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
alsa-devel@alsa-project.org,
Brent Weatherall <brentweatherall@gmail.com>
Subject: Re: PandaBoard ES Audio Problems
Date: Thu, 31 Jan 2013 20:00:00 +0000 [thread overview]
Message-ID: <1359662400.10392.26.camel@loki> (raw)
In-Reply-To: <510AC999.2090205@ladisch.de>
On Thu, 2013-01-31 at 20:44 +0100, Clemens Ladisch wrote:
>
> The problem is that the kernel driver returns wrong min/max values.
>
> > Liam Girdwood wrote:
> >> The OMAP4 ABE driver doesn't actually know the exact constraints if
> >> there is not a valid playback path between source PCM and sink (it will
> >> still throw out anything insane though). This is because it can route
> >> audio from most of it's PCMs to most of it's components, e.g. HS, HF,
> >> BT, MODEM, Earpiece, etc where some components have different
> >> constraints. It's possible that you dont have a path in your case.
>
> In theory, what the driver should do is:
> - don't allow the PCM device to be opened if there is no valid route
> configuration (or just never allow a completely invalid
> configuration); and
Ah, this was my initial design too :)
Some userspace software will actually and validly open a PCM, configure
some mixers and then perform a hw_params() -> trigger(). So locking out
the PCM at open() for invalid paths breaks some userspace code.
> - while the PCM device is open, lock the route configuration, or
We cant do this either as we have to support runtime switching between
different use cases (that use different back end components) e.g. MP3
playback to Phonecall
> - if changing the route during playback is necessary, allow to set
> only those routes that are possible with the current PCM
> configuration.
We do this already, but will first try and fixup any of the
configuration differences in the DSP so that the userspace operation
succeeds.
I guess Peter/Brent will have to look at the min/max values in more
detail.
Liam
next prev parent reply other threads:[~2013-01-31 20:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 16:51 PandaBoard ES Audio Problems Brent Weatherall
2013-01-31 17:28 ` Clemens Ladisch
2013-01-31 18:23 ` Liam Girdwood
2013-01-31 19:24 ` Brent Weatherall
2013-01-31 19:44 ` Clemens Ladisch
2013-01-31 19:50 ` Brent Weatherall
2013-01-31 20:00 ` Liam Girdwood [this message]
2013-01-31 22:13 ` Brent Weatherall
2013-02-01 8:29 ` Liam Girdwood
2013-02-01 10:51 ` Peter Ujfalusi
2013-02-01 10:56 ` Michael Trimarchi
2013-01-31 19:50 ` Liam Girdwood
2013-02-01 6:57 ` Takashi Iwai
2013-02-01 12:53 ` Peter Ujfalusi
2013-02-06 15:10 ` [PATCH 0/2] ASoC: OMAP4+ABE (ubuntu): Might fix OpenMax on PandaBoard Peter Ujfalusi
2013-02-06 15:10 ` [PATCH 1/2] ASoC: omap-abe-mmap: Make the hwrule function to be more generic Peter Ujfalusi
2013-02-06 15:10 ` [PATCH 2/2] ASoC: omap-abe-mmap: Place constraint to buffer size as well Peter Ujfalusi
2013-02-06 15:37 ` [PATCH 0/2] ASoC: OMAP4+ABE (ubuntu): Might fix OpenMax on PandaBoard Brent Weatherall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359662400.10392.26.camel@loki \
--to=liam.r.girdwood@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=brentweatherall@gmail.com \
--cc=clemens@ladisch.de \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).