From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: brentweatherall@gmail.com
Cc: liam.r.girdwood@linux.intel.com, alsa-devel@alsa-project.org,
michael@amarulasolutions.com, clemens@ladisch.de,
s-guiriec@ti.com
Subject: [PATCH 1/2] ASoC: omap-abe-mmap: Make the hwrule function to be more generic
Date: Wed, 6 Feb 2013 16:10:08 +0100 [thread overview]
Message-ID: <1360163409-25607-2-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1360163409-25607-1-git-send-email-peter.ujfalusi@ti.com>
Avoid using defines to get the snd_interval we are about to constrain.
rule->var holds the correct ID.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
sound/soc/omap/omap-abe-mmap.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/sound/soc/omap/omap-abe-mmap.c b/sound/soc/omap/omap-abe-mmap.c
index 92c240b..e5654c9 100644
--- a/sound/soc/omap/omap-abe-mmap.c
+++ b/sound/soc/omap/omap-abe-mmap.c
@@ -87,18 +87,17 @@ irqreturn_t abe_irq_handler(int irq, void *dev_id)
return IRQ_HANDLED;
}
-static int omap_abe_hwrule_period_step(struct snd_pcm_hw_params *params,
+static int omap_abe_hwrule_size_step(struct snd_pcm_hw_params *params,
struct snd_pcm_hw_rule *rule)
{
- struct snd_interval *period_size = hw_param_interval(params,
- SNDRV_PCM_HW_PARAM_PERIOD_SIZE);
unsigned int rate = params_rate(params);
/* 44.1kHz has the same iteration number as 48kHz */
rate = (rate == 44100) ? 48000 : rate;
/* ABE requires chunks of 250us worth of data */
- return snd_interval_step(period_size, 0, rate / 4000);
+ return snd_interval_step(hw_param_interval(params, rule->var), 0,
+ rate / 4000);
}
static int aess_open(struct snd_pcm_substream *substream)
@@ -128,7 +127,7 @@ static int aess_open(struct snd_pcm_substream *substream)
*/
ret = snd_pcm_hw_rule_add(substream->runtime, 0,
SNDRV_PCM_HW_PARAM_PERIOD_SIZE,
- omap_abe_hwrule_period_step,
+ omap_abe_hwrule_size_step,
NULL,
SNDRV_PCM_HW_PARAM_PERIOD_SIZE, -1);
break;
--
1.8.1.1
next prev parent reply other threads:[~2013-02-06 15:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 16:51 PandaBoard ES Audio Problems Brent Weatherall
2013-01-31 17:28 ` Clemens Ladisch
2013-01-31 18:23 ` Liam Girdwood
2013-01-31 19:24 ` Brent Weatherall
2013-01-31 19:44 ` Clemens Ladisch
2013-01-31 19:50 ` Brent Weatherall
2013-01-31 20:00 ` Liam Girdwood
2013-01-31 22:13 ` Brent Weatherall
2013-02-01 8:29 ` Liam Girdwood
2013-02-01 10:51 ` Peter Ujfalusi
2013-02-01 10:56 ` Michael Trimarchi
2013-01-31 19:50 ` Liam Girdwood
2013-02-01 6:57 ` Takashi Iwai
2013-02-01 12:53 ` Peter Ujfalusi
2013-02-06 15:10 ` [PATCH 0/2] ASoC: OMAP4+ABE (ubuntu): Might fix OpenMax on PandaBoard Peter Ujfalusi
2013-02-06 15:10 ` Peter Ujfalusi [this message]
2013-02-06 15:10 ` [PATCH 2/2] ASoC: omap-abe-mmap: Place constraint to buffer size as well Peter Ujfalusi
2013-02-06 15:37 ` [PATCH 0/2] ASoC: OMAP4+ABE (ubuntu): Might fix OpenMax on PandaBoard Brent Weatherall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360163409-25607-2-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=brentweatherall@gmail.com \
--cc=clemens@ladisch.de \
--cc=liam.r.girdwood@linux.intel.com \
--cc=michael@amarulasolutions.com \
--cc=s-guiriec@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).