From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] ALSA: get rid of CONFIG_SND_VERBOSE_PRINTK Date: Mon, 03 Jun 2013 13:49:00 -0700 Message-ID: <1370292540.2385.13.camel@joe-AO722> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from labridge.com (perches-mx.perches.com [206.117.179.246]) by alsa0.perex.cz (Postfix) with ESMTP id 27EA526500C for ; Mon, 3 Jun 2013 22:49:02 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Alan Stern Cc: Takashi Iwai , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Mon, 2013-06-03 at 16:40 -0400, Alan Stern wrote: > On Mon, 3 Jun 2013, Joe Perches wrote: > > On Mon, 2013-06-03 at 16:18 -0400, Alan Stern wrote: > > > According to Takashi Iwai, CONFIG_SND_VERBOSE_PRINTK is "useless". All > > > it does is add filenames and line numbers to certain log messages. > > > This patch gets rid of it. > > [] > > > Updating all the snd_printk() and snd_printd() calls will be a huge > > > job. Getting rid of the verbose logging is a lot easier, so that's > > > where I'm starting. > > > > cocci and emacs can make this pretty simple. > > I wish they could, but I sincerely doubt that this conversion can be > mechanized. At least, not if it is to be done correctly. Completely mechanized/automated no, simpler though. I still think the snd_printk uses should be converted to: _( *foo, fmt, ...) [] > > Please change the __snd_printk macros to remove __FILE__ and > > __LINE__ (or 0, and 0) to remove some text from the objects. > > Will do. OK. > I should have realized that originally... No worries, it's a process. Thanks for getting it started.