alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Ashish Chavan <ashish.chavan@kpitcummins.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	alsa-devel <alsa-devel@alsa-project.org>,
	"kiran.padwal" <kiran.padwal@kpitcummins.com>, lrg <lrg@ti.com>,
	David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [PATCH] ASoC: codecs: da9055: Update driver name to fix breakage due to pmic driver with same name
Date: Thu, 11 Jul 2013 17:06:16 +0530	[thread overview]
Message-ID: <1373542576.9286.101.camel@matrix> (raw)
In-Reply-To: <20130708112613.GQ27646@sirena.org.uk>


> > I feel that some info is missing from your view. DA9055 is CODEC + PMIC
> > but with two different I2C addresses. Actually it is a case of two
> > different chips enclosed in a single die. There is NO interconnection
> > between CODEC and PMIC inside DA9055. To me, this seems enough reason to
> > make two drivers independent from each other and not let one part know
> > about the existence of other. Actually in near future, there may be
> > three variants of this chip,
> 
> This is very similar to things like the TI palmas chips - they have
> multiple functions on different I2C addresses.  The chip still gets
> instantiated a single time and then the subdevices are instantiated
> like a MFD by the core device.

I have had a look at palmas implementation. It seems to me that a
significant change to both PMIC and CODEC drivers is required to make
them inline with palmas structure. It will also need a thorough testing
cycle for both. I am afraid that we may not have immediate bandwidth to
accommodate this level of change. Is it possible that in first go we
just fix the breakage due to name collision so that both drivers remain
usable. And in second iteration, we restructure both of them as you
suggested?

  reply	other threads:[~2013-07-11 11:21 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-05 11:47 [PATCH] ASoC: codecs: da9055: Update driver name to fix breakage due to pmic driver with same name Ashish Chavan
2013-07-05 11:44 ` Mark Brown
2013-07-05 13:35   ` Ashish Chavan
2013-07-05 13:37     ` Mark Brown
2013-07-08  7:54       ` Ashish Chavan
2013-07-08 11:26         ` Mark Brown
2013-07-11 11:36           ` Ashish Chavan [this message]
2013-07-17 10:36             ` Mark Brown
2013-07-22  8:43               ` Ashish Chavan
2013-07-22 10:02                 ` Mark Brown
2013-07-29 15:06                   ` Ashish Chavan
2013-07-29 16:01                     ` [alsa-devel] " Mark Brown
2013-08-05  7:55                       ` Ashish Chavan
2013-08-05 14:42                         ` Mark Brown
2013-08-05 15:51                           ` Ashish Chavan
2013-08-05 16:23                             ` [alsa-devel] " Mark Brown
2013-08-29 12:08                               ` Ashish Chavan
2013-09-02  9:49                                 ` Opensource [Adam Thomson]
2013-09-02 10:38                                   ` [alsa-devel] " Mark Brown
2013-09-02 15:38                                     ` Opensource [Adam Thomson]
2013-09-02 17:41                                       ` Mark Brown
2013-09-04 16:13                                         ` Opensource [Adam Thomson]
2013-09-04 18:34                                           ` Mark Brown
2013-09-06 14:17                                             ` Opensource [Adam Thomson]
2013-09-09 11:26                                               ` Mark Brown
2013-09-10 13:05                                                 ` Opensource [Adam Thomson]
2013-09-10 17:07                                                   ` Mark Brown
2013-09-12 17:11                                                     ` Opensource [Adam Thomson]
2013-09-12 21:58                                                       ` [alsa-devel] " Mark Brown
2013-09-13 15:05                                                         ` Opensource [Adam Thomson]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373542576.9286.101.camel@matrix \
    --to=ashish.chavan@kpitcummins.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=david.chen@diasemi.com \
    --cc=kiran.padwal@kpitcummins.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).