[PATCH] ASoC: pcm: Use the power efficient workqueue for delayed powerdown

[PATCH] ASoC: pcm: Use the power efficient workqueue for delayed powerdown

[Mark Brown]

From: Mark Brown <broonie@linaro.org>

There is no need to use a normal per-CPU workqueue for delayed power downs
as they're not timing or performance critical and waking up a core for them
would defeat some of the point.

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 sound/soc/soc-pcm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index b6c6403..f4f68cb 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -411,8 +411,9 @@ static int soc_pcm_close(struct snd_pcm_substream *substream)
 		} else {
 			/* start delayed pop wq here for playback streams */
 			rtd->pop_wait = 1;
-			schedule_delayed_work(&rtd->delayed_work,
-				msecs_to_jiffies(rtd->pmdown_time));
+			queue_delayed_work(system_power_efficient_wq,
+					   &rtd->delayed_work,
+					   msecs_to_jiffies(rtd->pmdown_time));
 		}
 	} else {
 		/* capture streams can be powered down now */
-- 
1.8.3.2

Re: [PATCH] ASoC: pcm: Use the power efficient workqueue for delayed powerdown

[Viresh Kumar]

On 18 July 2013 16:24, Mark Brown <broonie@kernel.org> wrote:
> From: Mark Brown <broonie@linaro.org>
>
> There is no need to use a normal per-CPU workqueue for delayed power downs
> as they're not timing or performance critical and waking up a core for them
> would defeat some of the point.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>  sound/soc/soc-pcm.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index b6c6403..f4f68cb 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -411,8 +411,9 @@ static int soc_pcm_close(struct snd_pcm_substream *substream)
>                 } else {
>                         /* start delayed pop wq here for playback streams */
>                         rtd->pop_wait = 1;
> -                       schedule_delayed_work(&rtd->delayed_work,
> -                               msecs_to_jiffies(rtd->pmdown_time));
> +                       queue_delayed_work(system_power_efficient_wq,
> +                                          &rtd->delayed_work,
> +                                          msecs_to_jiffies(rtd->pmdown_time));
>                 }
>         } else {
>                 /* capture streams can be powered down now */

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>

Re: [PATCH] ASoC: pcm: Use the power efficient workqueue for delayed powerdown

[Liam Girdwood]

On Thu, 2013-07-18 at 11:54 +0100, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
> 
> There is no need to use a normal per-CPU workqueue for delayed power downs
> as they're not timing or performance critical and waking up a core for them
> would defeat some of the point.
> 
> Signed-off-by: Mark Brown <broonie@linaro.org>

Acked-by: Liam Girdwood <liam.r.girdwood@intel.com>

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.