From: Wang Xingchao <xingchao.wang@linux.intel.com>
To: alsa-devel@alsa-project.org, tiwai@suse.de,
david.henningsson@canonical.com
Cc: Wang Xingchao <xingchao.wang@linux.intel.com>,
xingchao.wang@intel.com, liam.r.girdwood@intel.com
Subject: [PATCH 2/3] ALSA: hda - WAKEEN feature enabling for runtime pm
Date: Mon, 22 Jul 2013 03:19:17 -0400 [thread overview]
Message-ID: <1374477558-14074-2-git-send-email-xingchao.wang@linux.intel.com> (raw)
In-Reply-To: <1374477558-14074-1-git-send-email-xingchao.wang@linux.intel.com>
With runtime power save feature enabled, Headphone hotplug
event will not be detected while controller/codec in D3. HDA has
feature WAKEEN to let codec wake up system if controller is in D3 or
system in S3.(HDA Spec 4.5.9.2/3). Codec can send out INT or wake up
controller depending on whether CIE or GIE enabled.(Figure 4, Interupt
structure).
The controller must be in RESET mode after enter runtime-suspend, otherwise
it will not be waken up even if codec send out wake-up event. And STATESTS
will be cleared after controller brought out of RESET mode.
This patch only enable WAKEEN for runtime-suspend(Controller D3) mode,
not for system S3 mode. with tool "evtest", Headphone hotplug events
could be cought and reported successfully.
Signed-off-by: Wang Xingchao <xingchao.wang@linux.intel.com>
---
sound/pci/hda/hda_intel.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 8860dd5..a7ac7fd 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2970,6 +2970,11 @@ static int azx_runtime_suspend(struct device *dev)
{
struct snd_card *card = dev_get_drvdata(dev);
struct azx *chip = card->private_data;
+ int status;
+
+ /* enable controller wake up event */
+ azx_writew(chip, WAKEEN, azx_readw(chip, WAKEEN) |
+ STATESTS_INT_MASK);
azx_stop_chip(chip);
azx_enter_link_reset(chip);
@@ -2983,11 +2988,31 @@ static int azx_runtime_resume(struct device *dev)
{
struct snd_card *card = dev_get_drvdata(dev);
struct azx *chip = card->private_data;
+ struct hda_bus *bus;
+ struct hda_codec *codec;
+ int status;
if (chip->driver_caps & AZX_DCAPS_I915_POWERWELL)
hda_display_power(true);
+
+ /* Read STATESTS before controller reset */
+ status = azx_readw(chip, STATESTS);
+
azx_init_pci(chip);
azx_init_chip(chip, 1);
+
+ bus = chip->bus;
+ if (status && bus) {
+ list_for_each_entry(codec, &bus->codec_list, list)
+ if (status & (1 << codec->addr))
+ queue_delayed_work(codec->bus->workq,
+ &codec->jackpoll_work, codec->jackpoll_interval);
+ }
+
+ /* disable controller Wake Up event*/
+ azx_writew(chip, WAKEEN, azx_readw(chip, WAKEEN) &
+ ~STATESTS_INT_MASK);
+
return 0;
}
--
1.8.3.2
next prev parent reply other threads:[~2013-07-22 6:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 7:19 [PATCH 1/3] ALSA: hda - jack poll once if jackpoll_interval==0 Wang Xingchao
2013-07-22 7:19 ` Wang Xingchao [this message]
2013-07-23 7:36 ` [PATCH 2/3] ALSA: hda - WAKEEN feature enabling for runtime pm David Henningsson
2013-07-23 8:06 ` Wang, Xingchao
2013-07-23 8:09 ` Wang, Xingchao
2013-07-24 10:48 ` Takashi Iwai
2013-07-24 11:36 ` David Henningsson
2013-07-24 12:24 ` Takashi Iwai
2013-07-25 12:54 ` Wang, Xingchao
2013-07-24 13:40 ` Wang, Xingchao
2013-07-24 13:52 ` Takashi Iwai
2013-07-24 14:02 ` Takashi Iwai
2013-07-24 14:06 ` Wang, Xingchao
2013-07-22 7:19 ` [PATCH 3/3] ALSA: hda - use azx_writew() for 16-bit length register Wang Xingchao
2013-07-24 14:00 ` Takashi Iwai
2013-07-24 10:08 ` [PATCH 1/3] ALSA: hda - jack poll once if jackpoll_interval==0 Takashi Iwai
2013-07-24 10:31 ` David Henningsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374477558-14074-2-git-send-email-xingchao.wang@linux.intel.com \
--to=xingchao.wang@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=liam.r.girdwood@intel.com \
--cc=tiwai@suse.de \
--cc=xingchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).