From: Wang Xingchao <xingchao.wang@linux.intel.com>
To: alsa-devel@alsa-project.org, tiwai@suse.de,
david.henningsson@canonical.com
Cc: Wang Xingchao <xingchao.wang@linux.intel.com>,
xingchao.wang@intel.com, liam.r.girdwood@intel.com
Subject: [PATCH 3/3] ALSA: hda - use azx_writew() for 16-bit length register
Date: Mon, 22 Jul 2013 03:19:18 -0400 [thread overview]
Message-ID: <1374477558-14074-3-git-send-email-xingchao.wang@linux.intel.com> (raw)
In-Reply-To: <1374477558-14074-1-git-send-email-xingchao.wang@linux.intel.com>
Register STATESTS is 16-bit length, use correct API for read/write.
Signed-off-by: Wang Xingchao <xingchao.wang@linux.intel.com>
---
sound/pci/hda/hda_intel.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index a7ac7fd..c6f7c19 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1160,7 +1160,7 @@ static int azx_reset(struct azx *chip, int full_reset)
goto __skip;
/* clear STATESTS */
- azx_writeb(chip, STATESTS, STATESTS_INT_MASK);
+ azx_writew(chip, STATESTS, STATESTS_INT_MASK);
/* reset controller */
azx_enter_link_reset(chip);
@@ -1242,7 +1242,7 @@ static void azx_int_clear(struct azx *chip)
}
/* clear STATESTS */
- azx_writeb(chip, STATESTS, STATESTS_INT_MASK);
+ azx_writew(chip, STATESTS, STATESTS_INT_MASK);
/* clear rirb status */
azx_writeb(chip, RIRBSTS, RIRB_INT_MASK);
@@ -1451,8 +1451,8 @@ static irqreturn_t azx_interrupt(int irq, void *dev_id)
#if 0
/* clear state status int */
- if (azx_readb(chip, STATESTS) & 0x04)
- azx_writeb(chip, STATESTS, 0x04);
+ if (azx_readw(chip, STATESTS) & 0x04)
+ azx_writew(chip, STATESTS, 0x04);
#endif
spin_unlock(&chip->reg_lock);
--
1.8.3.2
next prev parent reply other threads:[~2013-07-22 6:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 7:19 [PATCH 1/3] ALSA: hda - jack poll once if jackpoll_interval==0 Wang Xingchao
2013-07-22 7:19 ` [PATCH 2/3] ALSA: hda - WAKEEN feature enabling for runtime pm Wang Xingchao
2013-07-23 7:36 ` David Henningsson
2013-07-23 8:06 ` Wang, Xingchao
2013-07-23 8:09 ` Wang, Xingchao
2013-07-24 10:48 ` Takashi Iwai
2013-07-24 11:36 ` David Henningsson
2013-07-24 12:24 ` Takashi Iwai
2013-07-25 12:54 ` Wang, Xingchao
2013-07-24 13:40 ` Wang, Xingchao
2013-07-24 13:52 ` Takashi Iwai
2013-07-24 14:02 ` Takashi Iwai
2013-07-24 14:06 ` Wang, Xingchao
2013-07-22 7:19 ` Wang Xingchao [this message]
2013-07-24 14:00 ` [PATCH 3/3] ALSA: hda - use azx_writew() for 16-bit length register Takashi Iwai
2013-07-24 10:08 ` [PATCH 1/3] ALSA: hda - jack poll once if jackpoll_interval==0 Takashi Iwai
2013-07-24 10:31 ` David Henningsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374477558-14074-3-git-send-email-xingchao.wang@linux.intel.com \
--to=xingchao.wang@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=liam.r.girdwood@intel.com \
--cc=tiwai@suse.de \
--cc=xingchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).