Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: Remove unused dapm_get_snd_card() and dapm_get_soc_card()
Date: Tue, 23 Jul 2013 13:49:42 +0100	[thread overview]
Message-ID: <1374583782.2475.26.camel@loki> (raw)
In-Reply-To: <1374570745-32224-1-git-send-email-lars@metafoo.de>

On Tue, 2013-07-23 at 11:12 +0200, Lars-Peter Clausen wrote:
> These two functions were added two years ago in commit 4805608 ("ASoC: dapm -
> Add methods to retrieve snd_card and soc_card from dapm context.") but have
> remained unused so far. Considering that the dapm context actually has a direct
> pointer to the card the functions also seem to be unnecessary. E.g. the
> expressions 'dapm_get_soc_card(dapm)' and 'dapm->card' yield the same result.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---

Peter may have a user for these, but maybe not ?

Liam

  reply	other threads:[~2013-07-23 12:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  9:12 [PATCH] ASoC: Remove unused dapm_get_snd_card() and dapm_get_soc_card() Lars-Peter Clausen
2013-07-23 12:49 ` Liam Girdwood [this message]
2013-07-23 17:36   ` Mark Brown
2013-07-23 17:57     ` Lars-Peter Clausen
2013-07-23 19:32       ` Mark Brown
2013-07-23 19:47         ` Lars-Peter Clausen
2013-07-24  0:10           ` Mark Brown
2013-07-23 19:14   ` Peter Ujfalusi
2013-07-23 12:56 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374583782.2475.26.camel@loki \
    --to=liam.r.girdwood@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox