From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Daniel Mack <zonque@gmail.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
ALSA development <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: Ambiguous DAPM widget names and DPCM
Date: Thu, 25 Jul 2013 20:53:38 +0100 [thread overview]
Message-ID: <1374782018.2371.61.camel@loki> (raw)
In-Reply-To: <20130725124859.GC9858@sirena.org.uk>
On Thu, 2013-07-25 at 13:48 +0100, Mark Brown wrote:
> On Thu, Jul 25, 2013 at 02:24:54PM +0200, Daniel Mack wrote:
> > On 23.07.2013 20:30, Mark Brown wrote:
>
> > > The prefix mechanism is intended to address this; however it's only
> > > currently supported for CODECs. If we move the prefixes to components
> > > then they should be usable for CPU DAIs.
>
> > But that's a static string as well. How can we distiguish between two
> > Codecs of the same type, or two McASP instances?
>
> The point is to give a different prefix to each device; giving the same
> prefix to different devices rather defeats the poinnt.
I don't think we had any issues with DAI global naming on OMAP4 (we were
probably just lucky I guess). We had several physical McBSP and several
logical McPDM interfaces that were used by the ABE and they were
globally connected in the machine driver using the DAI device name e.g.
"omap-mcbsp.1"
Fwiw, I've just looked at Peter's topic/ti-audio-next-bnw-wip branch at
gitorious.org:omap-audio/linux-audio.git and can see we may be missing a
couple of patches that can affect the DAI connections i.e.
35f485c300d514225710af4a436c987b15b9b690. These are not required for
DPCM on Haswell (where I connect to DAIs SSP0 and SSP1) and were written
before Mark upstreamed the CODEC<->CODEC work which also supported
widget DAI connections. It may be that some of these patches are still
required for some configurations. Peter, you may be able to drop some of
these patches since CODEC<->CODEC provides similar DAI widget
functionality.
We probably have to address the local/global context for widget naming
as Mark suggests. I guess that the global context will only apply to the
machine driver whilst the local context will only be used for component
drivers. This may just mean some changes for machine drivers in the way
we connect to component driver widgets.
Liam
next prev parent reply other threads:[~2013-07-25 19:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 8:30 Ambiguous DAPM widget names and DPCM Daniel Mack
2013-07-23 12:30 ` Mark Brown
2013-07-23 15:34 ` Daniel Mack
2013-07-23 18:30 ` Mark Brown
2013-07-25 12:24 ` Daniel Mack
2013-07-25 12:48 ` Mark Brown
2013-07-25 19:53 ` Liam Girdwood [this message]
2013-07-26 9:13 ` Peter Ujfalusi
2013-07-23 12:48 ` Liam Girdwood
2014-03-21 16:50 ` Patrick Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374782018.2371.61.camel@loki \
--to=liam.r.girdwood@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).