* [PATCH] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION
@ 2013-07-29 9:40 Vinod Koul
2013-07-29 11:58 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Vinod Koul @ 2013-07-29 9:40 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai, Vinod Koul, stable
the return value of SNDRV_COMPRESS_VERSION always return default -ENOTTY as the
return value was never updated for this call
assign return value from put_user()
Reported-by: Haynes <hgeorge@codeaurora.org>
CC: stable@vger.kernel.org
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
sound/core/compress_offload.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
index 99db892..9896954 100644
--- a/sound/core/compress_offload.c
+++ b/sound/core/compress_offload.c
@@ -743,7 +743,7 @@ static long snd_compr_ioctl(struct file *f, unsigned int cmd, unsigned long arg)
mutex_lock(&stream->device->lock);
switch (_IOC_NR(cmd)) {
case _IOC_NR(SNDRV_COMPRESS_IOCTL_VERSION):
- put_user(SNDRV_COMPRESS_VERSION,
+ retval = put_user(SNDRV_COMPRESS_VERSION,
(int __user *)arg) ? -EFAULT : 0;
break;
case _IOC_NR(SNDRV_COMPRESS_GET_CAPS):
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION
2013-07-29 9:40 [PATCH] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION Vinod Koul
@ 2013-07-29 11:58 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2013-07-29 11:58 UTC (permalink / raw)
To: Vinod Koul; +Cc: alsa-devel, stable
At Mon, 29 Jul 2013 15:10:22 +0530,
Vinod Koul wrote:
>
> the return value of SNDRV_COMPRESS_VERSION always return default -ENOTTY as the
> return value was never updated for this call
> assign return value from put_user()
>
> Reported-by: Haynes <hgeorge@codeaurora.org>
> CC: stable@vger.kernel.org
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Thanks, applied.
Takashi
> ---
> sound/core/compress_offload.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> index 99db892..9896954 100644
> --- a/sound/core/compress_offload.c
> +++ b/sound/core/compress_offload.c
> @@ -743,7 +743,7 @@ static long snd_compr_ioctl(struct file *f, unsigned int cmd, unsigned long arg)
> mutex_lock(&stream->device->lock);
> switch (_IOC_NR(cmd)) {
> case _IOC_NR(SNDRV_COMPRESS_IOCTL_VERSION):
> - put_user(SNDRV_COMPRESS_VERSION,
> + retval = put_user(SNDRV_COMPRESS_VERSION,
> (int __user *)arg) ? -EFAULT : 0;
> break;
> case _IOC_NR(SNDRV_COMPRESS_GET_CAPS):
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION
@ 2013-07-28 14:34 Vinod Koul
2013-07-29 9:53 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Vinod Koul @ 2013-07-28 14:34 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai, Vinod Koul, stable
Reported-by: Haynes <hgeorge@codeaurora.org>
CC: stable@vger.kernel.org
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
sound/core/compress_offload.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
index 99db892..9896954 100644
--- a/sound/core/compress_offload.c
+++ b/sound/core/compress_offload.c
@@ -743,7 +743,7 @@ static long snd_compr_ioctl(struct file *f, unsigned int cmd, unsigned long arg)
mutex_lock(&stream->device->lock);
switch (_IOC_NR(cmd)) {
case _IOC_NR(SNDRV_COMPRESS_IOCTL_VERSION):
- put_user(SNDRV_COMPRESS_VERSION,
+ retval = put_user(SNDRV_COMPRESS_VERSION,
(int __user *)arg) ? -EFAULT : 0;
break;
case _IOC_NR(SNDRV_COMPRESS_GET_CAPS):
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION
2013-07-28 14:34 Vinod Koul
@ 2013-07-29 9:53 ` Takashi Iwai
2013-07-29 9:46 ` Vinod Koul
0 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2013-07-29 9:53 UTC (permalink / raw)
To: Vinod Koul; +Cc: alsa-devel, stable
At Sun, 28 Jul 2013 20:04:03 +0530,
Vinod Koul wrote:
>
> Reported-by: Haynes <hgeorge@codeaurora.org>
> CC: stable@vger.kernel.org
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
The fix is trivial, but please give a bit more description so that
people can understand what this commit does and why it's needed,
without reading the code change but only from the patch description.
thanks,
Takashi
> ---
> sound/core/compress_offload.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> index 99db892..9896954 100644
> --- a/sound/core/compress_offload.c
> +++ b/sound/core/compress_offload.c
> @@ -743,7 +743,7 @@ static long snd_compr_ioctl(struct file *f, unsigned int cmd, unsigned long arg)
> mutex_lock(&stream->device->lock);
> switch (_IOC_NR(cmd)) {
> case _IOC_NR(SNDRV_COMPRESS_IOCTL_VERSION):
> - put_user(SNDRV_COMPRESS_VERSION,
> + retval = put_user(SNDRV_COMPRESS_VERSION,
> (int __user *)arg) ? -EFAULT : 0;
> break;
> case _IOC_NR(SNDRV_COMPRESS_GET_CAPS):
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION
2013-07-29 9:53 ` Takashi Iwai
@ 2013-07-29 9:46 ` Vinod Koul
0 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2013-07-29 9:46 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, stable
On Mon, Jul 29, 2013 at 11:53:15AM +0200, Takashi Iwai wrote:
> At Sun, 28 Jul 2013 20:04:03 +0530,
> Vinod Koul wrote:
> >
> > Reported-by: Haynes <hgeorge@codeaurora.org>
> > CC: stable@vger.kernel.org
> > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
>
> The fix is trivial, but please give a bit more description so that
> people can understand what this commit does and why it's needed,
> without reading the code change but only from the patch description.
Sure, I have sent updated one with the updated changelog
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-29 11:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-29 9:40 [PATCH] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION Vinod Koul
2013-07-29 11:58 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2013-07-28 14:34 Vinod Koul
2013-07-29 9:53 ` Takashi Iwai
2013-07-29 9:46 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).