From: Fabio Estevam <fabio.estevam@freescale.com>
To: broonie@kernel.org
Cc: Fabio Estevam <fabio.estevam@freescale.com>, alsa-devel@alsa-project.org
Subject: [PATCH 2/3] ASoC: ep93xx-i2s: Remove unnecessary dev_set_drvdata()
Date: Mon, 26 Aug 2013 09:25:14 -0300 [thread overview]
Message-ID: <1377519915-23998-2-git-send-email-fabio.estevam@freescale.com> (raw)
In-Reply-To: <1377519915-23998-1-git-send-email-fabio.estevam@freescale.com>
Driver core clears the driver data to NULL after device_release or on probe
failure, so just remove it from here.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
sound/soc/cirrus/ep93xx-i2s.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/cirrus/ep93xx-i2s.c b/sound/soc/cirrus/ep93xx-i2s.c
index f23f331..a57643d 100644
--- a/sound/soc/cirrus/ep93xx-i2s.c
+++ b/sound/soc/cirrus/ep93xx-i2s.c
@@ -408,7 +408,6 @@ static int ep93xx_i2s_probe(struct platform_device *pdev)
return 0;
fail_put_lrclk:
- dev_set_drvdata(&pdev->dev, NULL);
clk_put(info->lrclk);
fail_put_sclk:
clk_put(info->sclk);
@@ -423,7 +422,6 @@ static int ep93xx_i2s_remove(struct platform_device *pdev)
struct ep93xx_i2s_info *info = dev_get_drvdata(&pdev->dev);
snd_soc_unregister_component(&pdev->dev);
- dev_set_drvdata(&pdev->dev, NULL);
clk_put(info->lrclk);
clk_put(info->sclk);
clk_put(info->mclk);
--
1.8.1.2
next prev parent reply other threads:[~2013-08-26 12:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 12:25 [PATCH 1/3] ASoC: fsl_ssi: Remove unnecessary dev_set_drvdata() Fabio Estevam
2013-08-26 12:25 ` Fabio Estevam [this message]
2013-08-29 12:21 ` [PATCH 2/3] ASoC: ep93xx-i2s: " Mark Brown
2013-08-26 12:25 ` [PATCH 3/3] ASoC: designware_i2s: " Fabio Estevam
2013-08-29 12:18 ` Mark Brown
2013-08-26 19:42 ` [PATCH 1/3] ASoC: fsl_ssi: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377519915-23998-2-git-send-email-fabio.estevam@freescale.com \
--to=fabio.estevam@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).