alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ALSA: ctxfi: Staticize local symbols
@ 2013-09-13  9:44 Sachin Kamat
  2013-09-13  9:44 ` [PATCH 2/2] ALSA: hda/ca0132: Staticize codec_send_command Sachin Kamat
  2013-09-13 12:38 ` [PATCH 1/2] ALSA: ctxfi: Staticize local symbols Takashi Iwai
  0 siblings, 2 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-09-13  9:44 UTC (permalink / raw)
  To: alsa-devel; +Cc: tiwai, sachin.kamat

Local symbols used only in this file are made static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 sound/pci/ctxfi/ctdaio.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/ctxfi/ctdaio.c b/sound/pci/ctxfi/ctdaio.c
index 0c00eb4..84f86bf 100644
--- a/sound/pci/ctxfi/ctdaio.c
+++ b/sound/pci/ctxfi/ctdaio.c
@@ -33,7 +33,7 @@ struct daio_rsc_idx {
 	unsigned short right;
 };
 
-struct daio_rsc_idx idx_20k1[NUM_DAIOTYP] = {
+static struct daio_rsc_idx idx_20k1[NUM_DAIOTYP] = {
 	[LINEO1] = {.left = 0x00, .right = 0x01},
 	[LINEO2] = {.left = 0x18, .right = 0x19},
 	[LINEO3] = {.left = 0x08, .right = 0x09},
@@ -44,7 +44,7 @@ struct daio_rsc_idx idx_20k1[NUM_DAIOTYP] = {
 	[SPDIFI1] = {.left = 0x95, .right = 0x9d},
 };
 
-struct daio_rsc_idx idx_20k2[NUM_DAIOTYP] = {
+static struct daio_rsc_idx idx_20k2[NUM_DAIOTYP] = {
 	[LINEO1] = {.left = 0x40, .right = 0x41},
 	[LINEO2] = {.left = 0x60, .right = 0x61},
 	[LINEO3] = {.left = 0x50, .right = 0x51},
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ALSA: hda/ca0132: Staticize codec_send_command
  2013-09-13  9:44 [PATCH 1/2] ALSA: ctxfi: Staticize local symbols Sachin Kamat
@ 2013-09-13  9:44 ` Sachin Kamat
  2013-09-13 12:38 ` [PATCH 1/2] ALSA: ctxfi: Staticize local symbols Takashi Iwai
  1 sibling, 0 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-09-13  9:44 UTC (permalink / raw)
  To: alsa-devel; +Cc: tiwai, sachin.kamat

'codec_send_command' is used only in this file. Make it static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 sound/pci/hda/patch_ca0132.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index 6e9876f..54d1479 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -759,7 +759,7 @@ struct ca0132_spec {
 /*
  * CA0132 codec access
  */
-unsigned int codec_send_command(struct hda_codec *codec, hda_nid_t nid,
+static unsigned int codec_send_command(struct hda_codec *codec, hda_nid_t nid,
 		unsigned int verb, unsigned int parm, unsigned int *res)
 {
 	unsigned int response;
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ALSA: ctxfi: Staticize local symbols
  2013-09-13  9:44 [PATCH 1/2] ALSA: ctxfi: Staticize local symbols Sachin Kamat
  2013-09-13  9:44 ` [PATCH 2/2] ALSA: hda/ca0132: Staticize codec_send_command Sachin Kamat
@ 2013-09-13 12:38 ` Takashi Iwai
  1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2013-09-13 12:38 UTC (permalink / raw)
  To: Sachin Kamat; +Cc: alsa-devel

At Fri, 13 Sep 2013 15:14:21 +0530,
Sachin Kamat wrote:
> 
> Local symbols used only in this file are made static.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Thanks, applied both patches.


Takashi

> ---
>  sound/pci/ctxfi/ctdaio.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/ctxfi/ctdaio.c b/sound/pci/ctxfi/ctdaio.c
> index 0c00eb4..84f86bf 100644
> --- a/sound/pci/ctxfi/ctdaio.c
> +++ b/sound/pci/ctxfi/ctdaio.c
> @@ -33,7 +33,7 @@ struct daio_rsc_idx {
>  	unsigned short right;
>  };
>  
> -struct daio_rsc_idx idx_20k1[NUM_DAIOTYP] = {
> +static struct daio_rsc_idx idx_20k1[NUM_DAIOTYP] = {
>  	[LINEO1] = {.left = 0x00, .right = 0x01},
>  	[LINEO2] = {.left = 0x18, .right = 0x19},
>  	[LINEO3] = {.left = 0x08, .right = 0x09},
> @@ -44,7 +44,7 @@ struct daio_rsc_idx idx_20k1[NUM_DAIOTYP] = {
>  	[SPDIFI1] = {.left = 0x95, .right = 0x9d},
>  };
>  
> -struct daio_rsc_idx idx_20k2[NUM_DAIOTYP] = {
> +static struct daio_rsc_idx idx_20k2[NUM_DAIOTYP] = {
>  	[LINEO1] = {.left = 0x40, .right = 0x41},
>  	[LINEO2] = {.left = 0x60, .right = 0x61},
>  	[LINEO3] = {.left = 0x50, .right = 0x51},
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-13 12:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-13  9:44 [PATCH 1/2] ALSA: ctxfi: Staticize local symbols Sachin Kamat
2013-09-13  9:44 ` [PATCH 2/2] ALSA: hda/ca0132: Staticize codec_send_command Sachin Kamat
2013-09-13 12:38 ` [PATCH 1/2] ALSA: ctxfi: Staticize local symbols Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).