From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
alsa-devel@alsa-project.org
Subject: [PATCH] ASoC: core utils: Dont set DMA params for BE substreams
Date: Fri, 13 Sep 2013 18:09:47 +0100 [thread overview]
Message-ID: <1379092188-7385-3-git-send-email-liam.r.girdwood@linux.intel.com> (raw)
In-Reply-To: <1379092188-7385-1-git-send-email-liam.r.girdwood@linux.intel.com>
BE substreams dont require dummy DMA configs so dont set any.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
---
sound/soc/soc-utils.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/sound/soc/soc-utils.c b/sound/soc/soc-utils.c
index 29b211e..5e63365 100644
--- a/sound/soc/soc-utils.c
+++ b/sound/soc/soc-utils.c
@@ -75,7 +75,11 @@ static const struct snd_pcm_hardware dummy_dma_hardware = {
static int dummy_dma_open(struct snd_pcm_substream *substream)
{
- snd_soc_set_runtime_hwparams(substream, &dummy_dma_hardware);
+ struct snd_soc_pcm_runtime *rtd = substream->private_data;
+
+ /* BE's dont need dummy params */
+ if (!rtd->dai_link->no_pcm)
+ snd_soc_set_runtime_hwparams(substream, &dummy_dma_hardware);
return 0;
}
--
1.8.1.2
next prev parent reply other threads:[~2013-09-13 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 17:09 [PATCH] ASoC: core: Only add platform DAI widgets once Liam Girdwood
2013-09-13 17:09 ` [PATCH] ASoC: trace: Make sure trace header doesnt depend on any headers Liam Girdwood
2013-09-13 17:27 ` Mark Brown
2013-09-13 17:09 ` Liam Girdwood [this message]
2013-09-13 17:27 ` [PATCH] ASoC: core utils: Dont set DMA params for BE substreams Mark Brown
2013-09-13 17:09 ` [PATCH] ASoC: core: Add API for configuration of DAI FS Liam Girdwood
2013-09-13 17:26 ` Mark Brown
2013-09-16 10:28 ` Liam Girdwood
2013-09-16 11:05 ` Mark Brown
2013-09-16 11:32 ` Liam Girdwood
2013-09-13 17:28 ` [PATCH] ASoC: core: Only add platform DAI widgets once Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379092188-7385-3-git-send-email-liam.r.girdwood@linux.intel.com \
--to=liam.r.girdwood@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).