* [PATCH] ASoC: dapm: Ignore VMID widgets for target bias
@ 2013-10-05 17:26 Lars-Peter Clausen
2013-10-07 10:33 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2013-10-05 17:26 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, Lars-Peter Clausen
VMID widgets behave very similar to signal generator widgets. Both are always
considered to be powered up. This means that we need to ignore the VMID widgets
in the same way as signal generator widgets when calculating the DAPM context's
target bias level. Otherwise the presence of a VMID widget, regardless whether
it is on an active path or not, will cause the DAPM context to be powered up.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
sound/soc/soc-dapm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index c17c14c..177f8a1 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -1840,6 +1840,7 @@ static int dapm_power_widgets(struct snd_soc_card *card, int event)
*/
switch (w->id) {
case snd_soc_dapm_siggen:
+ case snd_soc_dapm_vmid:
break;
case snd_soc_dapm_supply:
case snd_soc_dapm_regulator_supply:
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: dapm: Ignore VMID widgets for target bias
2013-10-05 17:26 [PATCH] ASoC: dapm: Ignore VMID widgets for target bias Lars-Peter Clausen
@ 2013-10-07 10:33 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-10-07 10:33 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: alsa-devel, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 491 bytes --]
On Sat, Oct 05, 2013 at 07:26:17PM +0200, Lars-Peter Clausen wrote:
> VMID widgets behave very similar to signal generator widgets. Both are always
> considered to be powered up. This means that we need to ignore the VMID widgets
> in the same way as signal generator widgets when calculating the DAPM context's
> target bias level. Otherwise the presence of a VMID widget, regardless whether
> it is on an active path or not, will cause the DAPM context to be powered up.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-07 10:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-05 17:26 [PATCH] ASoC: dapm: Ignore VMID widgets for target bias Lars-Peter Clausen
2013-10-07 10:33 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).