alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Guido Aulisi <guido.aulisi@gmail.com>
To: Daniel Mack <zonque@gmail.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
	nicholas.bailey@glasgow.ac.uk
Subject: ALSA: snd-usb-usx2y: remove bogus frame checks
Date: Mon, 07 Oct 2013 23:29:50 +0200	[thread overview]
Message-ID: <1381181390.2193.11.camel@yoda.heavyware> (raw)

Hi,
I did some more testing on my US122:

I used my patch (see below) and it worked (with default nrpack=4), but I
got "should not be here with counts=42" errors, then after some time the
kernel crashed, but I couldn't copy the trace.

Then I set nrpack=1 and I got no "should not be here..." and it was more
stable, no crash. I only checked playback, not recording, nor MIDI, with
aplay I played some songs for about one hour...

I hope this can be useful. But I think there are other bugs in this
driver.

Ciao
Guido Aulisi

The patch is:

diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaudio.c
index 63fb521..cd16fcc 100644
--- a/sound/usb/usx2y/usbusx2yaudio.c
+++ b/sound/usb/usx2y/usbusx2yaudio.c
@@ -328,7 +328,7 @@ static void i_usX2Y_urb_complete(struct urb *urb)
                usX2Y_error_urb_status(usX2Y, subs, urb);
                return;
        }
-       if (likely((urb->start_frame & 0xFFFF) == (usX2Y->wait_iso_frame & 0xFFFF)))
+       if (likely((urb->start_frame & 0x03FF) == (usX2Y->wait_iso_frame & 0x03FF)))
                subs->completed_urb = urb;
        else {
                usX2Y_error_sequence(usX2Y, subs, urb);

             reply	other threads:[~2013-10-07 21:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-07 21:29 Guido Aulisi [this message]
2013-10-08  7:08 ` ALSA: snd-usb-usx2y: remove bogus frame checks Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381181390.2193.11.camel@yoda.heavyware \
    --to=guido.aulisi@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=nicholas.bailey@glasgow.ac.uk \
    --cc=tiwai@suse.de \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).