alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Sony vaio pro 13 (haswell)
@ 2013-10-11  8:18 David Henningsson
  2013-10-11  8:18 ` [PATCH v2 1/2] ALSA: hda - Fix microphone for Sony VAIO Pro 13 (Haswell model) David Henningsson
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: David Henningsson @ 2013-10-11  8:18 UTC (permalink / raw)
  To: tiwai, alsa-devel; +Cc: David Henningsson

Changes since v1:

 - Mic patch now applies to linux-stable branch linux-3.11.y cleanly
 - The two patches are now not connected to each other. I'll send a patch
   that connects them if/when we get some confirmation that this actually is
   a working headset mic pin.

David Henningsson (2):
  ALSA: hda - Fix microphone for Sony VAIO Pro 13 (Haswell model)
  ALSA: hda - Add a headset mic model for ALC269 and friends

 Documentation/sound/alsa/HD-Audio-Models.txt |    1 +
 sound/pci/hda/patch_realtek.c                |   24 ++++++++++++++++++++++++
 2 files changed, 25 insertions(+)

-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/2] ALSA: hda - Fix microphone for Sony VAIO Pro 13 (Haswell model)
  2013-10-11  8:18 [PATCH v2 0/2] Sony vaio pro 13 (haswell) David Henningsson
@ 2013-10-11  8:18 ` David Henningsson
  2013-10-11  8:18 ` [PATCH v2 2/2] ALSA: hda - Add a headset mic model for ALC269 and friends David Henningsson
  2013-10-11  8:26 ` [PATCH v2 0/2] Sony vaio pro 13 (haswell) Takashi Iwai
  2 siblings, 0 replies; 4+ messages in thread
From: David Henningsson @ 2013-10-11  8:18 UTC (permalink / raw)
  To: tiwai, alsa-devel; +Cc: David Henningsson, stable

The external mic showed up with a precense detect of "always present",
essentially disabling the internal mic. Therefore turn off presence
detection for this pin.

Note: The external mic seems not yet working, but an internal mic is
certainly better than no mic at all.

Cc: stable@vger.kernel.org
BugLink: https://bugs.launchpad.net/bugs/1227093
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 sound/pci/hda/patch_realtek.c |    9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ed9deb6..ae847fe 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -3528,6 +3528,7 @@ enum {
 	ALC269_FIXUP_HP_GPIO_LED,
 	ALC269_FIXUP_INV_DMIC,
 	ALC269_FIXUP_LENOVO_DOCK,
+	ALC286_FIXUP_SONY_MIC_NO_PRESENCE,
 	ALC269_FIXUP_PINCFG_NO_HP_TO_LINEOUT,
 	ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
 	ALC269_FIXUP_DELL2_MIC_NO_PRESENCE,
@@ -3740,6 +3741,13 @@ static const struct hda_fixup alc269_fixups[] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc_fixup_headset_mode_no_hp_mic,
 	},
+	[ALC286_FIXUP_SONY_MIC_NO_PRESENCE] = {
+		.type = HDA_FIXUP_PINS,
+		.v.pins = (const struct hda_pintbl[]) {
+			{ 0x18, 0x01a1913c }, /* use as headset mic, without its own jack detect */
+			{ }
+		},
+	},
 	[ALC269_FIXUP_ASUS_X101_FUNC] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc269_fixup_x101_headset_mic,
@@ -3894,6 +3902,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1043, 0x8398, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC),
 	SND_PCI_QUIRK(0x1043, 0x83ce, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC),
 	SND_PCI_QUIRK(0x1043, 0x8516, "ASUS X101CH", ALC269_FIXUP_ASUS_X101),
+	SND_PCI_QUIRK(0x104d, 0x90b6, "Sony VAIO Pro 13", ALC286_FIXUP_SONY_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x104d, 0x9073, "Sony VAIO", ALC275_FIXUP_SONY_VAIO_GPIO2),
 	SND_PCI_QUIRK(0x104d, 0x907b, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ),
 	SND_PCI_QUIRK(0x104d, 0x9084, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ),
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] ALSA: hda - Add a headset mic model for ALC269 and friends
  2013-10-11  8:18 [PATCH v2 0/2] Sony vaio pro 13 (haswell) David Henningsson
  2013-10-11  8:18 ` [PATCH v2 1/2] ALSA: hda - Fix microphone for Sony VAIO Pro 13 (Haswell model) David Henningsson
@ 2013-10-11  8:18 ` David Henningsson
  2013-10-11  8:26 ` [PATCH v2 0/2] Sony vaio pro 13 (haswell) Takashi Iwai
  2 siblings, 0 replies; 4+ messages in thread
From: David Henningsson @ 2013-10-11  8:18 UTC (permalink / raw)
  To: tiwai, alsa-devel; +Cc: David Henningsson

Using the headset mic model will cause the headset mic to be labeled 
"headset mic" instead of just "mic".

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 Documentation/sound/alsa/HD-Audio-Models.txt |    1 +
 sound/pci/hda/patch_realtek.c                |   15 +++++++++++++++
 2 files changed, 16 insertions(+)

diff --git a/Documentation/sound/alsa/HD-Audio-Models.txt b/Documentation/sound/alsa/HD-Audio-Models.txt
index f911e36..ba143cd 100644
--- a/Documentation/sound/alsa/HD-Audio-Models.txt
+++ b/Documentation/sound/alsa/HD-Audio-Models.txt
@@ -28,6 +28,7 @@ ALC269/270/275/276/28x/29x
   alc269-dmic		Enable ALC269(VA) digital mic workaround
   alc271-dmic		Enable ALC271X digital mic workaround
   inv-dmic		Inverted internal mic workaround
+  headset-mic		Indicates a combined headset (headphone+mic) jack
   lenovo-dock   	Enables docking station I/O for some Lenovos
   dell-headset-multi	Headset jack, which can also be used as mic-in
   dell-headset-dock	Headset jack (without mic-in), and also dock I/O
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ae847fe..79e6fe7 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2819,6 +2819,15 @@ static void alc269_fixup_hweq(struct hda_codec *codec,
 	alc_write_coef_idx(codec, 0x1e, coef | 0x80);
 }
 
+static void alc269_fixup_headset_mic(struct hda_codec *codec,
+				       const struct hda_fixup *fix, int action)
+{
+	struct alc_spec *spec = codec->spec;
+
+	if (action == HDA_FIXUP_ACT_PRE_PROBE)
+		spec->parse_flags |= HDA_PINCFG_HEADSET_MIC;
+}
+
 static void alc271_fixup_dmic(struct hda_codec *codec,
 			      const struct hda_fixup *fix, int action)
 {
@@ -3516,6 +3525,7 @@ enum {
 	ALC271_FIXUP_DMIC,
 	ALC269_FIXUP_PCM_44K,
 	ALC269_FIXUP_STEREO_DMIC,
+	ALC269_FIXUP_HEADSET_MIC,
 	ALC269_FIXUP_QUANTA_MUTE,
 	ALC269_FIXUP_LIFEBOOK,
 	ALC269_FIXUP_AMIC,
@@ -3615,6 +3625,10 @@ static const struct hda_fixup alc269_fixups[] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc269_fixup_stereo_dmic,
 	},
+	[ALC269_FIXUP_HEADSET_MIC] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = alc269_fixup_headset_mic,
+	},
 	[ALC269_FIXUP_QUANTA_MUTE] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc269_fixup_quanta_mute,
@@ -3988,6 +4002,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
 	{.id = ALC269_FIXUP_STEREO_DMIC, .name = "alc269-dmic"},
 	{.id = ALC271_FIXUP_DMIC, .name = "alc271-dmic"},
 	{.id = ALC269_FIXUP_INV_DMIC, .name = "inv-dmic"},
+	{.id = ALC269_FIXUP_HEADSET_MIC, .name = "headset-mic"},
 	{.id = ALC269_FIXUP_LENOVO_DOCK, .name = "lenovo-dock"},
 	{.id = ALC269_FIXUP_HP_GPIO_LED, .name = "hp-gpio-led"},
 	{.id = ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, .name = "dell-headset-multi"},
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 0/2] Sony vaio pro 13 (haswell)
  2013-10-11  8:18 [PATCH v2 0/2] Sony vaio pro 13 (haswell) David Henningsson
  2013-10-11  8:18 ` [PATCH v2 1/2] ALSA: hda - Fix microphone for Sony VAIO Pro 13 (Haswell model) David Henningsson
  2013-10-11  8:18 ` [PATCH v2 2/2] ALSA: hda - Add a headset mic model for ALC269 and friends David Henningsson
@ 2013-10-11  8:26 ` Takashi Iwai
  2 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2013-10-11  8:26 UTC (permalink / raw)
  To: David Henningsson; +Cc: alsa-devel

At Fri, 11 Oct 2013 10:18:44 +0200,
David Henningsson wrote:
> 
> Changes since v1:
> 
>  - Mic patch now applies to linux-stable branch linux-3.11.y cleanly
>  - The two patches are now not connected to each other. I'll send a patch
>    that connects them if/when we get some confirmation that this actually is
>    a working headset mic pin.
> 
> David Henningsson (2):
>   ALSA: hda - Fix microphone for Sony VAIO Pro 13 (Haswell model)
>   ALSA: hda - Add a headset mic model for ALC269 and friends

Both patches applied now.  Thanks.


Takashi

> 
>  Documentation/sound/alsa/HD-Audio-Models.txt |    1 +
>  sound/pci/hda/patch_realtek.c                |   24 ++++++++++++++++++++++++
>  2 files changed, 25 insertions(+)
> 
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-10-11  8:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-11  8:18 [PATCH v2 0/2] Sony vaio pro 13 (haswell) David Henningsson
2013-10-11  8:18 ` [PATCH v2 1/2] ALSA: hda - Fix microphone for Sony VAIO Pro 13 (Haswell model) David Henningsson
2013-10-11  8:18 ` [PATCH v2 2/2] ALSA: hda - Add a headset mic model for ALC269 and friends David Henningsson
2013-10-11  8:26 ` [PATCH v2 0/2] Sony vaio pro 13 (haswell) Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).