* [PATCH 3/6] ASoC: pcm1792a: Include linux/of.h header
2013-09-27 11:15 Sachin Kamat
@ 2013-09-27 11:15 ` Sachin Kamat
0 siblings, 0 replies; 13+ messages in thread
From: Sachin Kamat @ 2013-09-27 11:15 UTC (permalink / raw)
To: alsa-devel; +Cc: sachin.kamat, broonie, lgirdwood
'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
sound/soc/codecs/pcm1792a.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/pcm1792a.c b/sound/soc/codecs/pcm1792a.c
index 2a8eccf..6f14c50 100644
--- a/sound/soc/codecs/pcm1792a.c
+++ b/sound/soc/codecs/pcm1792a.c
@@ -28,6 +28,7 @@
#include <sound/initval.h>
#include <sound/soc.h>
#include <sound/tlv.h>
+#include <linux/of.h>
#include <linux/of_device.h>
#include "pcm1792a.h"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 1/6] ASoC: cs4271: Include linux/of.h header
@ 2013-10-11 11:53 Sachin Kamat
2013-10-11 11:53 ` [PATCH 2/6] ASoC: pcm1681: " Sachin Kamat
` (5 more replies)
0 siblings, 6 replies; 13+ messages in thread
From: Sachin Kamat @ 2013-10-11 11:53 UTC (permalink / raw)
To: alsa-devel; +Cc: sachin.kamat, broonie
'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
sound/soc/codecs/cs4271.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c
index a20f1bb..f6e9534 100644
--- a/sound/soc/codecs/cs4271.c
+++ b/sound/soc/codecs/cs4271.c
@@ -25,6 +25,7 @@
#include <linux/gpio.h>
#include <linux/i2c.h>
#include <linux/spi/spi.h>
+#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/of_gpio.h>
#include <sound/pcm.h>
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/6] ASoC: pcm1681: Include linux/of.h header
2013-10-11 11:53 [PATCH 1/6] ASoC: cs4271: Include linux/of.h header Sachin Kamat
@ 2013-10-11 11:53 ` Sachin Kamat
2013-10-16 18:00 ` Mark Brown
2013-10-11 11:53 ` [PATCH 3/6] ASoC: pcm1792a: " Sachin Kamat
` (4 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Sachin Kamat @ 2013-10-11 11:53 UTC (permalink / raw)
To: alsa-devel; +Cc: sachin.kamat, broonie
'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
sound/soc/codecs/pcm1681.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/pcm1681.c b/sound/soc/codecs/pcm1681.c
index 651ce09..54ea15b 100644
--- a/sound/soc/codecs/pcm1681.c
+++ b/sound/soc/codecs/pcm1681.c
@@ -21,6 +21,7 @@
#include <linux/gpio.h>
#include <linux/i2c.h>
#include <linux/regmap.h>
+#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/of_gpio.h>
#include <sound/pcm.h>
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/6] ASoC: pcm1792a: Include linux/of.h header
2013-10-11 11:53 [PATCH 1/6] ASoC: cs4271: Include linux/of.h header Sachin Kamat
2013-10-11 11:53 ` [PATCH 2/6] ASoC: pcm1681: " Sachin Kamat
@ 2013-10-11 11:53 ` Sachin Kamat
2013-10-16 18:01 ` Mark Brown
2013-10-11 11:53 ` [PATCH 4/6] ASoC: tas5086: " Sachin Kamat
` (3 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Sachin Kamat @ 2013-10-11 11:53 UTC (permalink / raw)
To: alsa-devel; +Cc: sachin.kamat, broonie
'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
sound/soc/codecs/pcm1792a.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/pcm1792a.c b/sound/soc/codecs/pcm1792a.c
index 2a8eccf..6f14c50 100644
--- a/sound/soc/codecs/pcm1792a.c
+++ b/sound/soc/codecs/pcm1792a.c
@@ -28,6 +28,7 @@
#include <sound/initval.h>
#include <sound/soc.h>
#include <sound/tlv.h>
+#include <linux/of.h>
#include <linux/of_device.h>
#include "pcm1792a.h"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 4/6] ASoC: tas5086: Include linux/of.h header
2013-10-11 11:53 [PATCH 1/6] ASoC: cs4271: Include linux/of.h header Sachin Kamat
2013-10-11 11:53 ` [PATCH 2/6] ASoC: pcm1681: " Sachin Kamat
2013-10-11 11:53 ` [PATCH 3/6] ASoC: pcm1792a: " Sachin Kamat
@ 2013-10-11 11:53 ` Sachin Kamat
2013-10-16 18:01 ` Mark Brown
2013-10-11 11:54 ` [PATCH 5/6] ASoC: tlv320aic3x: " Sachin Kamat
` (2 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Sachin Kamat @ 2013-10-11 11:53 UTC (permalink / raw)
To: alsa-devel; +Cc: sachin.kamat, broonie
'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
sound/soc/codecs/tas5086.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/tas5086.c b/sound/soc/codecs/tas5086.c
index 6d31d88..e7c9a08 100644
--- a/sound/soc/codecs/tas5086.c
+++ b/sound/soc/codecs/tas5086.c
@@ -37,6 +37,7 @@
#include <linux/i2c.h>
#include <linux/regmap.h>
#include <linux/spi/spi.h>
+#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/of_gpio.h>
#include <sound/pcm.h>
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 5/6] ASoC: tlv320aic3x: Include linux/of.h header
2013-10-11 11:53 [PATCH 1/6] ASoC: cs4271: Include linux/of.h header Sachin Kamat
` (2 preceding siblings ...)
2013-10-11 11:53 ` [PATCH 4/6] ASoC: tas5086: " Sachin Kamat
@ 2013-10-11 11:54 ` Sachin Kamat
2013-10-16 18:02 ` Mark Brown
2013-10-11 11:54 ` [PATCH 6/6] ASoC: atmel: " Sachin Kamat
2013-10-16 17:59 ` [PATCH 1/6] ASoC: cs4271: " Mark Brown
5 siblings, 1 reply; 13+ messages in thread
From: Sachin Kamat @ 2013-10-11 11:54 UTC (permalink / raw)
To: alsa-devel; +Cc: sachin.kamat, broonie
'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
sound/soc/codecs/tlv320aic3x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index 892c108..f8b9fa6 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -40,6 +40,7 @@
#include <linux/i2c.h>
#include <linux/gpio.h>
#include <linux/regulator/consumer.h>
+#include <linux/of.h>
#include <linux/of_gpio.h>
#include <linux/slab.h>
#include <sound/core.h>
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 6/6] ASoC: atmel: Include linux/of.h header
2013-10-11 11:53 [PATCH 1/6] ASoC: cs4271: Include linux/of.h header Sachin Kamat
` (3 preceding siblings ...)
2013-10-11 11:54 ` [PATCH 5/6] ASoC: tlv320aic3x: " Sachin Kamat
@ 2013-10-11 11:54 ` Sachin Kamat
2013-10-16 18:03 ` Mark Brown
2013-10-16 17:59 ` [PATCH 1/6] ASoC: cs4271: " Mark Brown
5 siblings, 1 reply; 13+ messages in thread
From: Sachin Kamat @ 2013-10-11 11:54 UTC (permalink / raw)
To: alsa-devel; +Cc: sachin.kamat, broonie
'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
sound/soc/atmel/sam9g20_wm8731.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
index 802717e..f15bff1 100644
--- a/sound/soc/atmel/sam9g20_wm8731.c
+++ b/sound/soc/atmel/sam9g20_wm8731.c
@@ -37,6 +37,7 @@
#include <linux/interrupt.h>
#include <linux/platform_device.h>
#include <linux/i2c.h>
+#include <linux/of.h>
#include <linux/atmel-ssc.h>
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 1/6] ASoC: cs4271: Include linux/of.h header
2013-10-11 11:53 [PATCH 1/6] ASoC: cs4271: Include linux/of.h header Sachin Kamat
` (4 preceding siblings ...)
2013-10-11 11:54 ` [PATCH 6/6] ASoC: atmel: " Sachin Kamat
@ 2013-10-16 17:59 ` Mark Brown
5 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2013-10-16 17:59 UTC (permalink / raw)
To: Sachin Kamat; +Cc: alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 622 bytes --]
On Fri, Oct 11, 2013 at 05:23:56PM +0530, Sachin Kamat wrote:
> 'of_match_ptr' is defined in linux/of.h. Include it explicitly.
I'll apply these but they're really on the borderline of what's worth
applying, it's a very minor change with no practical impact and there's
nothing considering if the inclusion of the header is just by accident
or if OF is something that is part of the API being offered.
What would make patches like this much easier to apply would be if they
were combined with further changes which removed the implicit include -
that would answer the above question and would help cut down on
rebuilds.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/6] ASoC: pcm1681: Include linux/of.h header
2013-10-11 11:53 ` [PATCH 2/6] ASoC: pcm1681: " Sachin Kamat
@ 2013-10-16 18:00 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2013-10-16 18:00 UTC (permalink / raw)
To: Sachin Kamat; +Cc: alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 146 bytes --]
On Fri, Oct 11, 2013 at 05:23:57PM +0530, Sachin Kamat wrote:
> 'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/6] ASoC: pcm1792a: Include linux/of.h header
2013-10-11 11:53 ` [PATCH 3/6] ASoC: pcm1792a: " Sachin Kamat
@ 2013-10-16 18:01 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2013-10-16 18:01 UTC (permalink / raw)
To: Sachin Kamat; +Cc: alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 146 bytes --]
On Fri, Oct 11, 2013 at 05:23:58PM +0530, Sachin Kamat wrote:
> 'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4/6] ASoC: tas5086: Include linux/of.h header
2013-10-11 11:53 ` [PATCH 4/6] ASoC: tas5086: " Sachin Kamat
@ 2013-10-16 18:01 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2013-10-16 18:01 UTC (permalink / raw)
To: Sachin Kamat; +Cc: alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 146 bytes --]
On Fri, Oct 11, 2013 at 05:23:59PM +0530, Sachin Kamat wrote:
> 'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 5/6] ASoC: tlv320aic3x: Include linux/of.h header
2013-10-11 11:54 ` [PATCH 5/6] ASoC: tlv320aic3x: " Sachin Kamat
@ 2013-10-16 18:02 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2013-10-16 18:02 UTC (permalink / raw)
To: Sachin Kamat; +Cc: alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 146 bytes --]
On Fri, Oct 11, 2013 at 05:24:00PM +0530, Sachin Kamat wrote:
> 'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 6/6] ASoC: atmel: Include linux/of.h header
2013-10-11 11:54 ` [PATCH 6/6] ASoC: atmel: " Sachin Kamat
@ 2013-10-16 18:03 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2013-10-16 18:03 UTC (permalink / raw)
To: Sachin Kamat; +Cc: alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 146 bytes --]
On Fri, Oct 11, 2013 at 05:24:01PM +0530, Sachin Kamat wrote:
> 'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2013-10-16 18:03 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-11 11:53 [PATCH 1/6] ASoC: cs4271: Include linux/of.h header Sachin Kamat
2013-10-11 11:53 ` [PATCH 2/6] ASoC: pcm1681: " Sachin Kamat
2013-10-16 18:00 ` Mark Brown
2013-10-11 11:53 ` [PATCH 3/6] ASoC: pcm1792a: " Sachin Kamat
2013-10-16 18:01 ` Mark Brown
2013-10-11 11:53 ` [PATCH 4/6] ASoC: tas5086: " Sachin Kamat
2013-10-16 18:01 ` Mark Brown
2013-10-11 11:54 ` [PATCH 5/6] ASoC: tlv320aic3x: " Sachin Kamat
2013-10-16 18:02 ` Mark Brown
2013-10-11 11:54 ` [PATCH 6/6] ASoC: atmel: " Sachin Kamat
2013-10-16 18:03 ` Mark Brown
2013-10-16 17:59 ` [PATCH 1/6] ASoC: cs4271: " Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2013-09-27 11:15 Sachin Kamat
2013-09-27 11:15 ` [PATCH 3/6] ASoC: pcm1792a: " Sachin Kamat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).