* [PATCH 1/2] ASoC: pcm1681: Fix max_register setting
@ 2013-10-12 9:24 Axel Lin
2013-10-12 9:26 ` [PATCH 2/2] ASoC: pcm1792a: " Axel Lin
2013-10-14 14:00 ` [PATCH 1/2] ASoC: pcm1681: " Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2013-10-12 9:24 UTC (permalink / raw)
To: Mark Brown; +Cc: Marek Belisko, alsa-devel, Liam Girdwood
According to the datasheet, the max_register is 13h.
ARRAY_SIZE(pcm1681_reg_defaults) + 1 is 18 which is wrong.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/pcm1681.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/pcm1681.c b/sound/soc/codecs/pcm1681.c
index 651ce09..c91eba5 100644
--- a/sound/soc/codecs/pcm1681.c
+++ b/sound/soc/codecs/pcm1681.c
@@ -270,7 +270,7 @@ MODULE_DEVICE_TABLE(of, pcm1681_dt_ids);
static const struct regmap_config pcm1681_regmap = {
.reg_bits = 8,
.val_bits = 8,
- .max_register = ARRAY_SIZE(pcm1681_reg_defaults) + 1,
+ .max_register = 0x13,
.reg_defaults = pcm1681_reg_defaults,
.num_reg_defaults = ARRAY_SIZE(pcm1681_reg_defaults),
.writeable_reg = pcm1681_writeable_reg,
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ASoC: pcm1792a: Fix max_register setting
2013-10-12 9:24 [PATCH 1/2] ASoC: pcm1681: Fix max_register setting Axel Lin
@ 2013-10-12 9:26 ` Axel Lin
2013-10-14 14:08 ` Mark Brown
2013-10-14 14:00 ` [PATCH 1/2] ASoC: pcm1681: " Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Axel Lin @ 2013-10-12 9:26 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Michael Trimarchi, Liam Girdwood
According to the datasheet, the max_register is register 23.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/pcm1792a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/pcm1792a.c b/sound/soc/codecs/pcm1792a.c
index 2a8eccf..7613181 100644
--- a/sound/soc/codecs/pcm1792a.c
+++ b/sound/soc/codecs/pcm1792a.c
@@ -188,7 +188,7 @@ MODULE_DEVICE_TABLE(of, pcm1792a_of_match);
static const struct regmap_config pcm1792a_regmap = {
.reg_bits = 8,
.val_bits = 8,
- .max_register = 24,
+ .max_register = 23,
.reg_defaults = pcm1792a_reg_defaults,
.num_reg_defaults = ARRAY_SIZE(pcm1792a_reg_defaults),
.writeable_reg = pcm1792a_writeable_reg,
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] ASoC: pcm1792a: Fix max_register setting
2013-10-12 9:26 ` [PATCH 2/2] ASoC: pcm1792a: " Axel Lin
@ 2013-10-14 14:08 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2013-10-14 14:08 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Michael Trimarchi, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 139 bytes --]
On Sat, Oct 12, 2013 at 05:26:49PM +0800, Axel Lin wrote:
> According to the datasheet, the max_register is register 23.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ASoC: pcm1681: Fix max_register setting
2013-10-12 9:24 [PATCH 1/2] ASoC: pcm1681: Fix max_register setting Axel Lin
2013-10-12 9:26 ` [PATCH 2/2] ASoC: pcm1792a: " Axel Lin
@ 2013-10-14 14:00 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2013-10-14 14:00 UTC (permalink / raw)
To: Axel Lin; +Cc: Marek Belisko, alsa-devel, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 192 bytes --]
On Sat, Oct 12, 2013 at 05:24:25PM +0800, Axel Lin wrote:
> According to the datasheet, the max_register is 13h.
> ARRAY_SIZE(pcm1681_reg_defaults) + 1 is 18 which is wrong.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-14 14:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-12 9:24 [PATCH 1/2] ASoC: pcm1681: Fix max_register setting Axel Lin
2013-10-12 9:26 ` [PATCH 2/2] ASoC: pcm1792a: " Axel Lin
2013-10-14 14:08 ` Mark Brown
2013-10-14 14:00 ` [PATCH 1/2] ASoC: pcm1681: " Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).