* [PATCH] sound/soc/fsl: remove leftover release_mem_region
@ 2013-10-13 17:38 Wolfram Sang
2013-10-13 18:36 ` Lars-Peter Clausen
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2013-10-13 17:38 UTC (permalink / raw)
To: alsa-devel
Cc: Lars-Peter Clausen, Wolfram Sang, Sascha Hauer, Liam Girdwood,
Mark Brown, Markus Pargmann, Shawn Guo
When converting this driver to devm_ioremap_resource, the removal of this now
unneeded function has been forgotten.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
sound/soc/fsl/imx-ssi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c
index f58bcd8..b2cc743 100644
--- a/sound/soc/fsl/imx-ssi.c
+++ b/sound/soc/fsl/imx-ssi.c
@@ -615,7 +615,6 @@ failed_pcm_dma:
failed_pcm_fiq:
snd_soc_unregister_component(&pdev->dev);
failed_register:
- release_mem_region(res->start, resource_size(res));
clk_disable_unprepare(ssi->clk);
failed_clk:
snd_soc_set_ac97_ops(NULL);
@@ -636,7 +635,6 @@ static int imx_ssi_remove(struct platform_device *pdev)
if (ssi->flags & IMX_SSI_USE_AC97)
ac97_ssi = NULL;
- release_mem_region(res->start, resource_size(res));
clk_disable_unprepare(ssi->clk);
snd_soc_set_ac97_ops(NULL);
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sound/soc/fsl: remove leftover release_mem_region
2013-10-13 17:38 [PATCH] sound/soc/fsl: remove leftover release_mem_region Wolfram Sang
@ 2013-10-13 18:36 ` Lars-Peter Clausen
0 siblings, 0 replies; 2+ messages in thread
From: Lars-Peter Clausen @ 2013-10-13 18:36 UTC (permalink / raw)
To: Wolfram Sang
Cc: alsa-devel, Sascha Hauer, Liam Girdwood, Mark Brown,
Markus Pargmann, Shawn Guo
On 10/13/2013 07:38 PM, Wolfram Sang wrote:
> When converting this driver to devm_ioremap_resource, the removal of this now
> unneeded function has been forgotten.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> sound/soc/fsl/imx-ssi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c
> index f58bcd8..b2cc743 100644
> --- a/sound/soc/fsl/imx-ssi.c
> +++ b/sound/soc/fsl/imx-ssi.c
> @@ -615,7 +615,6 @@ failed_pcm_dma:
> failed_pcm_fiq:
> snd_soc_unregister_component(&pdev->dev);
> failed_register:
> - release_mem_region(res->start, resource_size(res));
> clk_disable_unprepare(ssi->clk);
> failed_clk:
> snd_soc_set_ac97_ops(NULL);
> @@ -636,7 +635,6 @@ static int imx_ssi_remove(struct platform_device *pdev)
> if (ssi->flags & IMX_SSI_USE_AC97)
> ac97_ssi = NULL;
>
> - release_mem_region(res->start, resource_size(res));
This should trigger a warning about res being unused now.
> clk_disable_unprepare(ssi->clk);
> snd_soc_set_ac97_ops(NULL);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-13 18:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-13 17:38 [PATCH] sound/soc/fsl: remove leftover release_mem_region Wolfram Sang
2013-10-13 18:36 ` Lars-Peter Clausen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).