alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2] sound/soc/fsl: remove leftover release_mem_region
@ 2013-10-13 19:51 Wolfram Sang
  2013-10-14 13:21 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2013-10-13 19:51 UTC (permalink / raw)
  To: alsa-devel
  Cc: Lars-Peter Clausen, Wolfram Sang, Sascha Hauer, Liam Girdwood,
	Mark Brown, Markus Pargmann, Shawn Guo

When converting this driver to devm_ioremap_resource, the removal of this now
unneeded function has been forgotten.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---

V2: Remove now unused variable. Thanks to Lars-Peter for pointing out!

 sound/soc/fsl/imx-ssi.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c
index f58bcd8..0272289 100644
--- a/sound/soc/fsl/imx-ssi.c
+++ b/sound/soc/fsl/imx-ssi.c
@@ -615,7 +615,6 @@ failed_pcm_dma:
 failed_pcm_fiq:
 	snd_soc_unregister_component(&pdev->dev);
 failed_register:
-	release_mem_region(res->start, resource_size(res));
 	clk_disable_unprepare(ssi->clk);
 failed_clk:
 	snd_soc_set_ac97_ops(NULL);
@@ -625,7 +624,6 @@ failed_clk:
 
 static int imx_ssi_remove(struct platform_device *pdev)
 {
-	struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	struct imx_ssi *ssi = platform_get_drvdata(pdev);
 
 	imx_pcm_dma_exit(pdev);
@@ -636,7 +634,6 @@ static int imx_ssi_remove(struct platform_device *pdev)
 	if (ssi->flags & IMX_SSI_USE_AC97)
 		ac97_ssi = NULL;
 
-	release_mem_region(res->start, resource_size(res));
 	clk_disable_unprepare(ssi->clk);
 	snd_soc_set_ac97_ops(NULL);
 
-- 
1.8.4.rc3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH V2] sound/soc/fsl: remove leftover release_mem_region
  2013-10-13 19:51 [PATCH V2] sound/soc/fsl: remove leftover release_mem_region Wolfram Sang
@ 2013-10-14 13:21 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-10-14 13:21 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: alsa-devel, Lars-Peter Clausen, Sascha Hauer, Liam Girdwood,
	Markus Pargmann, Shawn Guo


[-- Attachment #1.1: Type: text/plain, Size: 200 bytes --]

On Sun, Oct 13, 2013 at 09:51:26PM +0200, Wolfram Sang wrote:
> When converting this driver to devm_ioremap_resource, the removal of this now
> unneeded function has been forgotten.

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-10-14 13:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-13 19:51 [PATCH V2] sound/soc/fsl: remove leftover release_mem_region Wolfram Sang
2013-10-14 13:21 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).