alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: tiwai@suse.de, alsa-devel@alsa-project.org,
	platform-driver-x86@vger.kernel.org, ibm-acpi@hmh.eng.br,
	alex.hung@canonical.com, hui.wang@canonical.com
Cc: David Henningsson <david.henningsson@canonical.com>
Subject: [RFC PATCH 0/2] Enable mute LEDs and mic mute LEDs on Thinkpad
Date: Wed, 16 Oct 2013 14:15:34 +0200	[thread overview]
Message-ID: <1381925736-11399-1-git-send-email-david.henningsson@canonical.com> (raw)

Hi!

These two patches bind the thinkpad-acpi and the snd-hda-intel drivers together
so that the mute and mic-mute LEDs correspond to the current mute/micmute status
of the internal sound card.

The patches are against Takashi's sound tree and are working on a
Thinkpad X220-tablet, but the patches are otherwise in draft quality. Which means
that there are several outstanding issues that would need feedback from upstream.

First, I'd like feedback on the connection between the drivers - Takashi suggested
that we could bind the drivers together like we've recently done when connecting
the snd-hda-intel and the i915 driver, so this follows a similar scheme, with
exported symbols from the thinkpad-acpi driver and a symbol_request on the
snd-hda-intel side.
This also opens up for future improvements so that the hardware mute/volume does
not need to be its own card, but instead properly integrate with the output it
actually controls on the kernel side.

Second, about the LEDs as a security feature. As implemented in these patches
there is no userspace interface at all, which would meet Matthew's concern about
that. A future improvement could be that an alsamixer control was added, that
allows the LED to be turned off, but not on. Which means, if PulseAudio or other
daemon knows that recording goes on from another source (e g bluetooth or network
connected mic) it could turn the mic mute LED off to indicate that to the user,
but the only way to turn the LED on is to actually mute the internal card's
hardware.

Finally, it is my hope that I will get some quick and constructive feedback so
we can have it all in order to be merged in time for the 3.13 kernel merge window.
I'll be at Linuxcon Europe next week to answer questions if you have any, and
we might also spend some time talking about it on the audio meeting on Monday.

Thanks in advance!

David Henningsson (2):
  thinkpad-acpi: Add mute and mic-mute LED functionality
  ALSA: hda - add connection to thinkpad_acpi to control mute/micmute
    LEDs

 drivers/platform/x86/thinkpad_acpi.c |   94 +++++++++++++++++++++++++++++++++-
 include/linux/thinkpad_acpi.h        |   10 ++++
 sound/pci/hda/patch_conexant.c       |   78 ++++++++++++++++++++++++++++
 3 files changed, 181 insertions(+), 1 deletion(-)
 create mode 100644 include/linux/thinkpad_acpi.h

-- 
1.7.9.5

             reply	other threads:[~2013-10-16 12:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16 12:15 David Henningsson [this message]
2013-10-16 12:15 ` [RFC PATCH 1/2] thinkpad-acpi: Add mute and mic-mute LED functionality David Henningsson
2013-10-16 12:35   ` Henrique de Moraes Holschuh
2013-10-16 13:09   ` Takashi Iwai
2013-10-16 14:34     ` David Henningsson
2013-10-16 12:15 ` [RFC PATCH 2/2] ALSA: hda - add connection to thinkpad_acpi to control mute/micmute LEDs David Henningsson
2013-10-16 14:55   ` Takashi Iwai
2013-10-16 21:08     ` David Henningsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381925736-11399-1-git-send-email-david.henningsson@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=alex.hung@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=hui.wang@canonical.com \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).