From: David Henningsson <david.henningsson@canonical.com>
To: alsa-devel@alsa-project.org, tiwai@suse.de
Cc: David Henningsson <david.henningsson@canonical.com>
Subject: [PATCH] hda-emu: Implement tpacpi_set_led
Date: Fri, 1 Nov 2013 08:17:27 +0100 [thread overview]
Message-ID: <1383290247-6852-1-git-send-email-david.henningsson@canonical.com> (raw)
This allows for testing the feature as well as avoiding a warning
when testing the relevant codecs.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
include/wrapper.h | 3 +--
snd-wrapper.c | 7 +++++++
2 files changed, 8 insertions(+), 2 deletions(-)
Note: the i915 power well functions probably needs implementing as well now
that symbol_request is changed, but this does not seem to be a problem here,
maybe because hda_i915 is not in the kernel/Makefile.am file?
diff --git a/include/wrapper.h b/include/wrapper.h
index f7dd65d..93a9f93 100644
--- a/include/wrapper.h
+++ b/include/wrapper.h
@@ -238,8 +238,7 @@ void mylock_write_unlock(int *lock, const char *file, int line);
/* FIXME */
#define IS_ENABLED(x) 1
-/* FIXME */
-#define symbol_request(x) NULL
+#define symbol_request(x) x
#define symbol_put(x)
static inline long copy_from_user(void *to, const void __user *from, unsigned long n)
diff --git a/snd-wrapper.c b/snd-wrapper.c
index 1ec8a49..dbc62c5 100644
--- a/snd-wrapper.c
+++ b/snd-wrapper.c
@@ -720,3 +720,10 @@ int snd_pcm_add_chmap_ctls(struct snd_pcm *pcm, int stream,
return 0;
}
EXPORT_SYMBOL_GPL(snd_pcm_add_chmap_ctls);
+
+int tpacpi_led_set(int whichled, bool on)
+{
+ hda_log(HDA_LOG_INFO, "Setting thinkpad LED %d to %s\n", whichled, on ? "on" : "off" );
+ return 0;
+}
+
--
1.7.9.5
next reply other threads:[~2013-11-01 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 7:17 David Henningsson [this message]
2013-11-01 9:48 ` [PATCH] hda-emu: Implement tpacpi_set_led Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383290247-6852-1-git-send-email-david.henningsson@canonical.com \
--to=david.henningsson@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).