alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: linus.walleij@linaro.org, Lee Jones <lee.jones@linaro.org>,
	alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Subject: [PATCH 12/13] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation
Date: Wed,  6 Nov 2013 10:16:24 +0000	[thread overview]
Message-ID: <1383732985-18928-13-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1383732985-18928-1-git-send-email-lee.jones@linaro.org>

If booting with full DT support (i.e. DMA too, the last piece of the
puzzle), then we don't need to use the compatible request channel call
back and, due to the work we laid down earlier in this patch-set, we
can use core function calls to populate the DMA slave_config. We also
require slightly different flags to inform the core that we 'are'
booting with DT.

Cc: alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 sound/soc/ux500/ux500_pcm.c | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/sound/soc/ux500/ux500_pcm.c b/sound/soc/ux500/ux500_pcm.c
index ce554de..acfec98 100644
--- a/sound/soc/ux500/ux500_pcm.c
+++ b/sound/soc/ux500/ux500_pcm.c
@@ -139,15 +139,33 @@ static const struct snd_dmaengine_pcm_config ux500_dmaengine_pcm_config = {
 	.prepare_slave_config = ux500_pcm_prepare_slave_config,
 };
 
+static const struct snd_dmaengine_pcm_config ux500_dmaengine_of_pcm_config = {
+	.pcm_hardware = &ux500_pcm_hw,
+	.prealloc_buffer_size = 128 * 1024,
+	.prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config,
+};
+
 int ux500_pcm_register_platform(struct platform_device *pdev)
 {
+	const struct snd_dmaengine_pcm_config *pcm_config;
+	struct device_node *np = pdev->dev.of_node;
+	unsigned int pcm_flags;
 	int ret;
 
-	ret = snd_dmaengine_pcm_register(&pdev->dev,
-			&ux500_dmaengine_pcm_config,
-			SND_DMAENGINE_PCM_FLAG_NO_RESIDUE |
-			SND_DMAENGINE_PCM_FLAG_COMPAT |
-			SND_DMAENGINE_PCM_FLAG_NO_DT);
+	if (np) {
+		pcm_config = &ux500_dmaengine_of_pcm_config;
+
+		pcm_flags = SND_DMAENGINE_PCM_FLAG_NO_RESIDUE |
+			SND_DMAENGINE_PCM_FLAG_COMPAT;
+	} else {
+		pcm_config = &ux500_dmaengine_pcm_config;
+
+		pcm_flags = SND_DMAENGINE_PCM_FLAG_NO_RESIDUE |
+			SND_DMAENGINE_PCM_FLAG_NO_DT |
+			SND_DMAENGINE_PCM_FLAG_COMPAT;
+	}
+
+	ret = snd_dmaengine_pcm_register(&pdev->dev, pcm_config, pcm_flags);
 	if (ret < 0) {
 		dev_err(&pdev->dev,
 			"%s: ERROR: Failed to register platform '%s' (%d)!\n",
-- 
1.8.1.2

  parent reply	other threads:[~2013-11-06 10:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06 10:16 [PATCH 00/13] ASoC: dma: ARM: ux500: Obtain DMA data from Device Tree Lee Jones
2013-11-06 10:16 ` [PATCH 07/13] ASoC: ux500_pcm: Extract MSP IDs " Lee Jones
2013-11-06 11:46   ` Linus Walleij
2013-11-06 10:16 ` [PATCH 08/13] ASoC: generic-dmaengine-pcm: Clear slave_config memory Lee Jones
2013-11-06 11:55   ` [alsa-devel] " Lars-Peter Clausen
2013-11-07 11:36   ` Mark Brown
2013-11-06 10:16 ` [PATCH 09/13] ASoC: Ux500: Match platform by device node when booting Device Tree Lee Jones
2013-11-06 11:47   ` Linus Walleij
2013-11-06 10:16 ` [PATCH 10/13] ASoC: ux500_pcm: Extend Device Tree support to deal with DMA data Lee Jones
2013-11-06 11:49   ` Linus Walleij
2013-11-06 10:16 ` [PATCH 11/13] ASoC: ux500: Store DMA data in the DAI differently in the pdata and DT case Lee Jones
2013-11-06 11:50   ` Linus Walleij
2013-11-06 10:16 ` Lee Jones [this message]
2013-11-06 11:51   ` [PATCH 12/13] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation Linus Walleij
2013-11-06 10:16 ` [PATCH 13/13] ASoC: ux500_pcm: Take out pointless dev_dbg() call Lee Jones
2013-11-06 11:52   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383732985-18928-13-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).