alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH] hda_intel: ratelimit "spurious response" message
@ 2013-11-07 19:55 Joe Perches
  2013-11-07 20:23 ` Takashi Iwai
  0 siblings, 1 reply; 11+ messages in thread
From: Joe Perches @ 2013-11-07 19:55 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel, LKML

dmesg here has a 100+ consecutive lines of:

[ 1464.219446] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
[ 1464.219451] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
[ 1464.219454] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
...

Ratelimit the message to reduce the dmesg log noise.

Coalesce the format while at it.

Signed-off-by: Joe Perches <joe@perches.com>
---
 sound/pci/hda/hda_intel.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 6e61a01..6e444ca 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -906,12 +906,12 @@ static void azx_update_rirb(struct azx *chip)
 			chip->rirb.res[addr] = res;
 			smp_wmb();
 			chip->rirb.cmds[addr]--;
-		} else
-			snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, "
-				   "last cmd=%#08x\n",
+		} else if (printk_ratelimit()) {
+			snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, last cmd=%#08x\n",
 				   pci_name(chip->pci),
 				   res, res_ex,
 				   chip->last_cmd[addr]);
+		}
 	}
 }
 

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2013-11-19  8:57 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-07 19:55 [RFC PATCH] hda_intel: ratelimit "spurious response" message Joe Perches
2013-11-07 20:23 ` Takashi Iwai
2013-11-07 20:28   ` Joe Perches
2013-11-08 10:59     ` Takashi Iwai
2013-11-09  4:41       ` Joe Perches
2013-11-14 17:28         ` Takashi Iwai
2013-11-14 17:52           ` Joe Perches
2013-11-15  6:34             ` Takashi Iwai
2013-11-15  6:56             ` Takashi Iwai
2013-11-19  8:40               ` Joe Perches
2013-11-19  8:57                 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).