From: Anssi Hannula <anssi.hannula@iki.fi>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: "Olivier Langlois" <olivier@trillion01.com>,
"Peter Frühberger" <fritsch@xbmc.org>
Subject: [PATCH 2/3] speaker-test: Always show chmap channel names if available
Date: Sun, 10 Nov 2013 20:29:18 +0200 [thread overview]
Message-ID: <1384108159-3421-2-git-send-email-anssi.hannula@iki.fi> (raw)
In-Reply-To: <1384108159-3421-1-git-send-email-anssi.hannula@iki.fi>
Currently speaker-test only uses channel names retrieved by
snd_pcm_chmap_long_name() when a channel map has been manually set.
However, the device may provide a default (or fixed) channel map that
differs from the traditional ALSA map, in which case wrong channel names
are shown.
Fix that by always using the name from the channel map when a channel
map is present.
Note that the names retrieved by snd_pcm_chmap_long_name() are not
currently localized via gettext.
Also note that Linux kernel HDMI driver reported wrong default channel
maps before 56cac413dd6d43af8355f5d1f90a199b540f73fc ("ALSA: hda - hdmi:
Fix reported channel map on common default layouts").
Signed-off-by: Anssi Hannula <anssi.hannula@iki.fi>
---
speaker-test/speaker-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/speaker-test/speaker-test.c b/speaker-test/speaker-test.c
index 274007d..82cc3b1 100644
--- a/speaker-test/speaker-test.c
+++ b/speaker-test/speaker-test.c
@@ -254,7 +254,7 @@ static int get_speaker_channel(int chn)
static const char *get_channel_name(int chn)
{
#ifdef CONFIG_SUPPORT_CHMAP
- if (channel_map_set && chn < channel_map->channels) {
+ if (channel_map && chn < channel_map->channels) {
const char *name = snd_pcm_chmap_long_name(channel_map->pos[chn]);
return name ? name : "Unknown";
}
--
1.8.1.5
next prev parent reply other threads:[~2013-11-10 18:29 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 18:10 [PATCH v3 0/5] ALSA: hda - hdmi: ATI/AMD multi-channel and HBR support Anssi Hannula
2013-10-24 18:10 ` [PATCH 1/5] ALSA: hda - hdmi: Allow HDA patches to customize more operations Anssi Hannula
2013-10-24 18:10 ` [PATCH 2/5] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support Anssi Hannula
2013-10-24 18:10 ` [PATCH 3/5] ALSA: hda - hdmi: Add ELD emulation for ATI/AMD codecs Anssi Hannula
2013-10-24 18:10 ` [PATCH 4/5] ALSA: hda - hdmi: Add HBR bitstreaming support for ATI/AMD HDMI codecs Anssi Hannula
2013-10-24 18:10 ` [PATCH 5/5] ALSA: hda - hdmi: Disable ramp-up/down for non-PCM on AMD codecs Anssi Hannula
2013-10-24 19:00 ` Anssi Hannula
2013-10-24 18:26 ` [PATCH v3 0/5] ALSA: hda - hdmi: ATI/AMD multi-channel and HBR support Anssi Hannula
2013-11-08 5:08 ` Olivier Langlois
2013-11-08 10:27 ` Anssi Hannula
2013-11-08 18:17 ` Olivier Langlois
2013-11-08 21:28 ` Olivier Langlois
2013-11-08 22:03 ` Anssi Hannula
2013-11-10 5:42 ` Olivier Langlois
2013-11-10 6:01 ` Anssi Hannula
2013-11-10 7:25 ` speaker-test chmap bugs (was: [PATCH v3 0/5] ALSA: hda - hdmi: ATI/AMD multi-channel and HBR support) Anssi Hannula
2013-11-10 18:29 ` [PATCH 1/3] speaker-test: Fix chmapped channel selection without specified chmap Anssi Hannula
2013-11-10 18:29 ` Anssi Hannula [this message]
2013-11-10 18:29 ` [PATCH 3/3] speaker-test: Show out-of-chmap channels as Unknown Anssi Hannula
2013-11-11 15:56 ` [PATCH 1/3] speaker-test: Fix chmapped channel selection without specified chmap Takashi Iwai
2013-11-11 20:23 ` Anssi Hannula
2013-11-11 22:04 ` [PATCH 1/3 v2] " Anssi Hannula
2013-11-12 8:11 ` Takashi Iwai
2013-11-12 12:34 ` Anssi Hannula
2013-11-12 13:08 ` Takashi Iwai
2013-11-12 6:35 ` [PATCH v3 0/5] ALSA: hda - hdmi: ATI/AMD multi-channel and HBR support Olivier Langlois
2013-11-14 0:04 ` Anssi Hannula
2013-11-09 8:35 ` Takashi Iwai
2013-10-24 23:04 ` Takashi Iwai
2013-10-25 16:54 ` Andre Heider
2013-10-25 17:13 ` Takashi Iwai
2013-10-25 17:23 ` Anssi Hannula
2013-10-25 18:25 ` Andre Heider
2013-10-28 17:52 ` Andre Heider
2013-10-28 18:12 ` Anssi Hannula
2013-10-28 18:17 ` Andre Heider
2013-10-28 18:25 ` Anssi Hannula
2013-10-28 18:35 ` Andre Heider
2013-10-28 20:35 ` Anssi Hannula
2013-10-28 22:00 ` Andre Heider
2013-10-28 22:42 ` Anssi Hannula
2013-10-28 23:15 ` Andre Heider
2013-10-29 19:52 ` LANGLOIS Olivier PIS -EXT
2013-10-29 20:30 ` Anssi Hannula
2013-10-28 23:19 ` [PATCH] drm/radeon/audio: fix missing multichannel PCM SAD in some cases Anssi Hannula
2013-10-31 23:38 ` Rafał Miłecki
2013-10-31 23:46 ` Rafał Miłecki
2013-10-31 23:52 ` Anssi Hannula
2013-11-02 1:01 ` Rafał Miłecki
2013-11-02 1:08 ` Anssi Hannula
2013-11-02 1:15 ` Rafał Miłecki
2013-11-02 1:03 ` Rafał Miłecki
2013-11-02 15:32 ` [PATCH v3 0/5] ALSA: hda - hdmi: ATI/AMD multi-channel and HBR support Anssi Hannula
2013-11-23 1:05 ` James Le Cuirot
2013-11-23 1:29 ` Anssi Hannula
2013-11-23 15:40 ` James Le Cuirot
2013-11-23 15:45 ` Anssi Hannula
2013-11-24 14:57 ` James Le Cuirot
2013-11-25 13:20 ` Anssi Hannula
2013-11-25 14:32 ` James Le Cuirot
2013-11-25 14:56 ` Anssi Hannula
2014-05-13 12:01 ` James Le Cuirot
2014-05-13 12:27 ` Anssi Hannula
2014-05-13 16:16 ` James Le Cuirot
2014-05-13 21:10 ` James Le Cuirot
2014-05-13 21:50 ` Anssi Hannula
2014-05-14 13:04 ` Deucher, Alexander
2014-05-14 13:19 ` James Le Cuirot
2013-11-25 15:07 ` Raymond Yau
2013-11-25 15:32 ` James Le Cuirot
2013-11-25 19:35 ` Anssi Hannula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384108159-3421-2-git-send-email-anssi.hannula@iki.fi \
--to=anssi.hannula@iki.fi \
--cc=alsa-devel@alsa-project.org \
--cc=fritsch@xbmc.org \
--cc=olivier@trillion01.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).