alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: soc-pcm: fix incorrect channels and sample_bits wiping off
@ 2013-11-19  9:57 Nicolin Chen
  2013-11-19 19:11 ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolin Chen @ 2013-11-19  9:57 UTC (permalink / raw)
  To: broonie, lgirdwood; +Cc: tiwai, alsa-devel

This patch wipes off the corresponding channels and sample_bits for codec_dai.

Signed-off-by: Nicolin Chen <b42378@freescale.com>
---
@Mark Brown
Sir, I find the previous symmetry patch hasn't been merged into for-next.
So are you willing to apply this one or let me refine the previous PATCH
and resend that one?

 sound/soc/soc-pcm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index e1c5a00..60d9cfb 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -452,8 +452,8 @@ static int soc_pcm_close(struct snd_pcm_substream *substream)
 
 	if (!codec_dai->active) {
 		codec_dai->rate = 0;
-		cpu_dai->channels = 0;
-		cpu_dai->sample_bits = 0;
+		codec_dai->channels = 0;
+		codec_dai->sample_bits = 0;
 	}
 
 	/* Muting the DAC suppresses artifacts caused during digital
-- 
1.8.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: soc-pcm: fix incorrect channels and sample_bits wiping off
  2013-11-19  9:57 [PATCH] ASoC: soc-pcm: fix incorrect channels and sample_bits wiping off Nicolin Chen
@ 2013-11-19 19:11 ` Mark Brown
  2013-11-20  2:06   ` Nicolin Chen
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2013-11-19 19:11 UTC (permalink / raw)
  To: Nicolin Chen; +Cc: tiwai, alsa-devel, lgirdwood


[-- Attachment #1.1: Type: text/plain, Size: 347 bytes --]

On Tue, Nov 19, 2013 at 05:57:54PM +0800, Nicolin Chen wrote:

> Sir, I find the previous symmetry patch hasn't been merged into for-next.
> So are you willing to apply this one or let me refine the previous PATCH
> and resend that one?

I applied this but squashed it down into the previous patch which is
probably what the resend would've done.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: soc-pcm: fix incorrect channels and sample_bits wiping off
  2013-11-19 19:11 ` Mark Brown
@ 2013-11-20  2:06   ` Nicolin Chen
  0 siblings, 0 replies; 3+ messages in thread
From: Nicolin Chen @ 2013-11-20  2:06 UTC (permalink / raw)
  To: Mark Brown; +Cc: tiwai, alsa-devel, lgirdwood

On Tue, Nov 19, 2013 at 07:11:19PM +0000, Mark Brown wrote:
> On Tue, Nov 19, 2013 at 05:57:54PM +0800, Nicolin Chen wrote:
> 
> > Sir, I find the previous symmetry patch hasn't been merged into for-next.
> > So are you willing to apply this one or let me refine the previous PATCH
> > and resend that one?
> 
> I applied this but squashed it down into the previous patch which is
> probably what the resend would've done.

Exactly. Thank you, sir.
Nicolin Chen

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-11-20  2:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-19  9:57 [PATCH] ASoC: soc-pcm: fix incorrect channels and sample_bits wiping off Nicolin Chen
2013-11-19 19:11 ` Mark Brown
2013-11-20  2:06   ` Nicolin Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).