From: Markus Pargmann <mpa@pengutronix.de>
To: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>, Timur Tabi <timur@tabi.org>
Cc: alsa-devel@alsa-project.org, Nicolin Chen <b42378@freescale.com>,
kernel@pengutronix.de, Markus Pargmann <mpa@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/9] ASoC: fsl-ssi: Add imx51-ssi and of_device_id matching
Date: Wed, 18 Dec 2013 12:57:39 +0100 [thread overview]
Message-ID: <1387367865-26391-4-git-send-email-mpa@pengutronix.de> (raw)
In-Reply-To: <1387367865-26391-1-git-send-email-mpa@pengutronix.de>
There is a small but significant difference between imx21-ssi and
imx51-ssi and above. imx21-ssi does not allow online reconfiguration of
some registers. They have to be configured at the beginning.
imx51-ssi has to reconfigure the SSI unit while it is running. Otherwise
it would not be possible to have two streams in parallel. The new SDMA
unit in imx51 and above has to be configured before the first DMA
request arrives. Therefor we need to setup TDMAE/RDMAE just before
starting the stream.
This patch introduces distinct imx51-ssi as compatible and adds
of_device_id matching in the probe function.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
sound/soc/fsl/fsl_ssi.c | 31 +++++++++++++++++++++++--------
1 file changed, 23 insertions(+), 8 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index e949ce5..a889df5 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -122,6 +122,13 @@ static inline void write_ssi_mask(u32 __iomem *addr, u32 clear, u32 set)
CCSR_SSI_SIER_TUE0_EN | CCSR_SSI_SIER_TFRC_EN)
#define FSLSSI_SISR_MASK (FSLSSI_SIER_DBG_RX_FLAGS | FSLSSI_SIER_DBG_TX_FLAGS)
+
+enum fsl_ssi_type {
+ FSL_SSI_MCP8610,
+ FSL_SSI_MX21,
+ FSL_SSI_MX51,
+};
+
/**
* fsl_ssi_private: per-SSI private data
*
@@ -184,6 +191,14 @@ struct fsl_ssi_private {
char name[1];
};
+static const struct of_device_id fsl_ssi_ids[] = {
+ { .compatible = "fsl,mpc8610-ssi", .data = (void *) FSL_SSI_MCP8610},
+ { .compatible = "fsl,imx51-ssi", .data = (void *) FSL_SSI_MX51},
+ { .compatible = "fsl,imx21-ssi", .data = (void *) FSL_SSI_MX21},
+ {}
+};
+MODULE_DEVICE_TABLE(of, fsl_ssi_ids);
+
/**
* fsl_ssi_isr: SSI interrupt handler
*
@@ -863,6 +878,8 @@ static int fsl_ssi_probe(struct platform_device *pdev)
int ret = 0;
struct device_attribute *dev_attr = NULL;
struct device_node *np = pdev->dev.of_node;
+ const struct of_device_id *of_id;
+ enum fsl_ssi_type hw_type;
const char *p, *sprop;
const uint32_t *iprop;
struct resource res;
@@ -877,6 +894,11 @@ static int fsl_ssi_probe(struct platform_device *pdev)
if (!of_device_is_available(np))
return -ENODEV;
+ of_id = of_match_device(fsl_ssi_ids, &pdev->dev);
+ if (!of_id)
+ return -EINVAL;
+ hw_type = (enum fsl_ssi_type) of_id->data;
+
/* We only support the SSI in "I2S Slave" mode */
sprop = of_get_property(np, "fsl,mode", NULL);
if (!sprop) {
@@ -953,7 +975,7 @@ static int fsl_ssi_probe(struct platform_device *pdev)
/* Older 8610 DTs didn't have the fifo-depth property */
ssi_private->fifo_depth = 8;
- if (of_device_is_compatible(pdev->dev.of_node, "fsl,imx21-ssi")) {
+ if (hw_type == FSL_SSI_MX21 || hw_type == FSL_SSI_MX51) {
u32 dma_events[2];
ssi_private->ssi_on_imx = true;
@@ -1139,13 +1161,6 @@ static int fsl_ssi_remove(struct platform_device *pdev)
return 0;
}
-static const struct of_device_id fsl_ssi_ids[] = {
- { .compatible = "fsl,mpc8610-ssi", },
- { .compatible = "fsl,imx21-ssi", },
- {}
-};
-MODULE_DEVICE_TABLE(of, fsl_ssi_ids);
-
static struct platform_driver fsl_ssi_driver = {
.driver = {
.name = "fsl-ssi-dai",
--
1.8.5.1
next prev parent reply other threads:[~2013-12-18 11:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 11:57 [PATCH v3 0/9] ASoC: fsl-ssi: offline/online configuration and cleanups Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 1/9] ASoC: fsl-ssi: Fix probe error handling Markus Pargmann
2013-12-19 13:03 ` Mark Brown
2013-12-20 9:52 ` Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 2/9] ASoC: fsl-ssi: Move sysfs stats to debugfs Markus Pargmann
2013-12-18 11:57 ` Markus Pargmann [this message]
2013-12-18 11:57 ` [PATCH v3 4/9] ASoC: fsl-ssi: Fix interrupt mapping and release Markus Pargmann
2013-12-20 9:05 ` Nicolin Chen
2013-12-20 10:31 ` Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 5/9] ASoC: fsl-ssi: Add offline_config flag Markus Pargmann
2013-12-19 13:16 ` Mark Brown
2013-12-20 10:08 ` Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 6/9] ASoC: fsl-ssi: Add configuration helper functions Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 7/9] ASoC: fsl-ssi: Move RX/TX configuration to seperate functions Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 8/9] ASoC: fsl-ssi: Drop ac97 specific trigger function Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 9/9] ARM: DTS: imx5* imx6*, use imx51-ssi Markus Pargmann
2013-12-18 13:58 ` Shawn Guo
2013-12-18 14:10 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387367865-26391-4-git-send-email-mpa@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=b42378@freescale.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawn.guo@linaro.org \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).