From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: linus.walleij@linaro.org, broonie@kernel.org,
alsa-devel@alsa-project.org, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 07/11] ASoC: ux500_pcm: Extend Device Tree support to deal with DMA data
Date: Thu, 19 Dec 2013 15:55:04 +0000 [thread overview]
Message-ID: <1387468508-12286-8-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1387468508-12286-1-git-send-email-lee.jones@linaro.org>
Soon we will strip out pdata support from the Ux500 set of ASoC drivers.
When this happens it will have to supply a DMA slave_config to the
dmaengine. At the moment a great deal of this comes from pdata via
AUXDATA. We need to become independent of this soon. This patch starts
the process by allocating memory for the associated data structures and
fetches the MSP id used for const struct indexing.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
sound/soc/ux500/ux500_msp_i2s.c | 56 ++++++++++++++++++++++++++++++-----------
1 file changed, 41 insertions(+), 15 deletions(-)
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 1ca8b08..7f2a4ac 100644
--- a/sound/soc/ux500/ux500_msp_i2s.c
+++ b/sound/soc/ux500/ux500_msp_i2s.c
@@ -646,6 +646,34 @@ int ux500_msp_i2s_close(struct ux500_msp *msp, unsigned int dir)
}
+int ux500_msp_i2s_of_init_msp(struct platform_device *pdev,
+ struct ux500_msp *msp,
+ struct msp_i2s_platform_data **platform_data)
+{
+ struct msp_i2s_platform_data *pdata;
+
+ *platform_data = devm_kzalloc(&pdev->dev,
+ sizeof(struct msp_i2s_platform_data),
+ GFP_KERNEL);
+ pdata = *platform_data;
+ if (!pdata)
+ return -ENOMEM;
+
+ msp->playback_dma_data.dma_cfg = devm_kzalloc(&pdev->dev,
+ sizeof(struct stedma40_chan_cfg),
+ GFP_KERNEL);
+ if (!msp->playback_dma_data.dma_cfg)
+ return -ENOMEM;
+
+ msp->capture_dma_data.dma_cfg = devm_kzalloc(&pdev->dev,
+ sizeof(struct stedma40_chan_cfg),
+ GFP_KERNEL);
+ if (!msp->capture_dma_data.dma_cfg)
+ return -ENOMEM;
+
+ return 0;
+}
+
int ux500_msp_i2s_init_msp(struct platform_device *pdev,
struct ux500_msp **msp_p,
struct msp_i2s_platform_data *platform_data)
@@ -653,30 +681,28 @@ int ux500_msp_i2s_init_msp(struct platform_device *pdev,
struct resource *res = NULL;
struct device_node *np = pdev->dev.of_node;
struct ux500_msp *msp;
+ int ret;
*msp_p = devm_kzalloc(&pdev->dev, sizeof(struct ux500_msp), GFP_KERNEL);
msp = *msp_p;
if (!msp)
return -ENOMEM;
- if (np) {
- if (!platform_data) {
- platform_data = devm_kzalloc(&pdev->dev,
- sizeof(struct msp_i2s_platform_data), GFP_KERNEL);
- if (!platform_data)
- return -ENOMEM;
- }
- } else
- if (!platform_data)
+ if (!platform_data) {
+ if (np) {
+ ret = ux500_msp_i2s_of_init_msp(pdev, msp,
+ &platform_data);
+ if (ret)
+ return ret;
+ } else
return -EINVAL;
+ } else {
+ msp->playback_dma_data.dma_cfg = platform_data->msp_i2s_dma_tx;
+ msp->capture_dma_data.dma_cfg = platform_data->msp_i2s_dma_rx;
+ msp->id = platform_data->id;
+ }
- dev_dbg(&pdev->dev, "%s: Enter (name: %s, id: %d).\n", __func__,
- pdev->name, platform_data->id);
-
- msp->id = platform_data->id;
msp->dev = &pdev->dev;
- msp->playback_dma_data.dma_cfg = platform_data->msp_i2s_dma_tx;
- msp->capture_dma_data.dma_cfg = platform_data->msp_i2s_dma_rx;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (res == NULL) {
--
1.8.3.2
next prev parent reply other threads:[~2013-12-19 15:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 15:54 [PATCH 00/10] ASoC: ARM: ux500: Better prepare for full Device Tree Lee Jones
2013-12-19 15:54 ` [PATCH 01/11] ARM: ux500: Don't use enums for MSP IDs - for easy DT conversion Lee Jones
2014-01-07 14:03 ` Linus Walleij
2014-01-07 14:11 ` Lee Jones
2014-01-07 14:19 ` Mark Brown
2014-01-07 14:44 ` Lee Jones
2014-01-07 15:36 ` Mark Brown
2013-12-19 15:54 ` [PATCH 02/11] ASoC: ab8500: Revert back to find_next_bit() Lee Jones
2013-12-19 16:06 ` Takashi Iwai
2013-12-19 16:48 ` Lee Jones
2013-12-19 17:29 ` Takashi Iwai
2013-12-20 14:02 ` Lee Jones
2013-12-20 14:23 ` Takashi Iwai
2013-12-23 10:38 ` Takashi Iwai
2013-12-19 15:55 ` [PATCH 03/11] ASoC: ux500: Provide better checking for Device Tree and/or Platform Data Lee Jones
2014-01-07 15:37 ` Mark Brown
2013-12-19 15:55 ` [PATCH 04/11] ASoC: Ux500: Match platform by device node when booting Device Tree Lee Jones
2014-01-07 15:37 ` Mark Brown
2013-12-19 15:55 ` [PATCH 05/11] ASoC: ux500_pcm: Stop pretending that we support varying address widths Lee Jones
2014-01-07 15:38 ` Mark Brown
2013-12-19 15:55 ` [PATCH 06/11] ASoC: ux500_pcm: Expect different saved DMA data when obtaining from DAI store Lee Jones
2014-01-07 15:38 ` Mark Brown
2013-12-19 15:55 ` Lee Jones [this message]
2014-01-07 15:38 ` [PATCH 07/11] ASoC: ux500_pcm: Extend Device Tree support to deal with DMA data Mark Brown
2013-12-19 15:55 ` [PATCH 08/11] ASoC: ux500: Store DMA data in the DAI differently in the pdata and DT case Lee Jones
2014-01-07 15:38 ` Mark Brown
2013-12-19 15:55 ` [PATCH 09/11] ASoC: ux500_pcm: Take out pointless dev_dbg() call Lee Jones
2014-01-07 15:38 ` Mark Brown
2013-12-19 15:55 ` [PATCH 10/11] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation Lee Jones
2014-01-07 15:39 ` Mark Brown
2013-12-19 15:55 ` [PATCH 11/11] ASoC: ux500: Dramatically reduce the size of the DAI driver data struct Lee Jones
2014-01-07 15:39 ` Mark Brown
2013-12-21 14:29 ` [PATCH 00/10] ASoC: ARM: ux500: Better prepare for full Device Tree Mark Brown
2013-12-21 17:19 ` Lee Jones
2014-01-07 14:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387468508-12286-8-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).