From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: [PATCH 09/19] ASoC: mxs: Don't set unused struct snd_pcm_hardware fields Date: Fri, 20 Dec 2013 14:20:15 +0100 Message-ID: <1387545625-19240-9-git-send-email-lars@metafoo.de> References: <1387545625-19240-1-git-send-email-lars@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-out-044.synserver.de (smtp-out-122.synserver.de [212.40.185.122]) by alsa0.perex.cz (Postfix) with ESMTP id 3F3B9265616 for ; Fri, 20 Dec 2013 15:19:40 +0100 (CET) In-Reply-To: <1387545625-19240-1-git-send-email-lars@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown , Liam Girdwood Cc: Fabio Estevam , alsa-devel@alsa-project.org, Lars-Peter Clausen , Shawn Guo List-Id: alsa-devel@alsa-project.org The ASoC core assumes that the PCM component of the ASoC card transparently moves data around and does not impose any restrictions on the memory layout or the transfer speed. It ignores all fields from the snd_pcm_hardware struct for the PCM driver that are related to this. Setting these fields in the PCM driver might suggest otherwise though, so rather not set them. Signed-off-by: Lars-Peter Clausen Cc: Shawn Guo Cc: Fabio Estevam --- sound/soc/mxs/mxs-pcm.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sound/soc/mxs/mxs-pcm.c b/sound/soc/mxs/mxs-pcm.c index 04a6b0d..2e0863a 100644 --- a/sound/soc/mxs/mxs-pcm.c +++ b/sound/soc/mxs/mxs-pcm.c @@ -36,11 +36,6 @@ static const struct snd_pcm_hardware snd_mxs_hardware = { SNDRV_PCM_INFO_RESUME | SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_HALF_DUPLEX, - .formats = SNDRV_PCM_FMTBIT_S16_LE | - SNDRV_PCM_FMTBIT_S20_3LE | - SNDRV_PCM_FMTBIT_S24_LE, - .channels_min = 2, - .channels_max = 2, .period_bytes_min = 32, .period_bytes_max = 8192, .periods_min = 1, -- 1.8.0