Re: [PATCH 2/2] ASoC: fsl: Allow to select individual common options

["Alexander Shiyan" <shc_work@mail.ru>]

Hello.

> On Wed, Feb 05, 2014 at 09:31:52PM +0400, Alexander Shiyan wrote:
> > This patch allow to select individual common sound options and
> > as a result allow using sound cards/codecs based on DT description.
> > 
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> >  sound/soc/fsl/Kconfig | 23 ++++++++++++++++++++---
> >  1 file changed, 20 insertions(+), 3 deletions(-)
> > 
> > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> > index ecc1092..ed74c19 100644
> > --- a/sound/soc/fsl/Kconfig
> > +++ b/sound/soc/fsl/Kconfig
> > @@ -1,14 +1,26 @@
> >  menu "SoC Audio for Freescale CPUs"
> >  
> > +comment "Common SoC Audio options for Freescale CPUs:"
> > +
> >  config SND_SOC_FSL_SAI
> >  	tristate
> >  	select SND_SOC_GENERIC_DMAENGINE_PCM
> 
> Why do you skip SND_SOC_FSL_SAI and SND_SOC_FSL_ESAI for the change?

My comments here are the same as for the patch 1/2.

...
> >  config SND_SOC_FSL_ESAI
> >  	tristate
> > @@ -21,7 +33,12 @@ config SND_SOC_IMX_PCM_DMA
> >  	select SND_SOC_GENERIC_DMAENGINE_PCM
> 
> Doesn't the simple card driver need this to work on IMX?

Simple card driver does not work for i.MX at now due to some other issues
which should be resolved in separate patches for that driver.
Just one example:
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-January/070697.html

Thanks.
---